Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Only define _HAS_EXCEPTIONS=0 for MSVC builds #3787

Open
siren186 opened this issue Sep 9, 2024 · 3 comments
Open

cmake: Only define _HAS_EXCEPTIONS=0 for MSVC builds #3787

siren186 opened this issue Sep 9, 2024 · 3 comments
Labels
Distribution Related to binary distribution enhancement Enhancement request windows Windows platform

Comments

@siren186
Copy link

siren186 commented Sep 9, 2024

_HAS_EXCEPTIONS=0 # Disable exceptions

This switch _HAS_EXCEPTIONS=0 will not disalbe exceptions, on the contrary, it brings some problems.
See:
pocoproject/poco#4668
nodejs/node-addon-api#85

@siren186 siren186 added the bug Bug report label Sep 9, 2024
@siren186
Copy link
Author

siren186 commented Sep 9, 2024

See alse: Tencent/wcdb@077c061

@magreenblatt
Copy link
Collaborator

Chromium defines this value for MSVC builds (see here), and we need to match the Chromium configuration. If you think this is incorrect you can raise an issue with Chromium at https://crbug.com.

@magreenblatt magreenblatt closed this as not planned Won't fix, can't repro, duplicate, stale Sep 27, 2024
@magreenblatt
Copy link
Collaborator

magreenblatt commented Sep 27, 2024

More specifically, we could modify the CMake config to only define _HAS_EXCEPTIONS=0 when building with MSVC. However, MSVC is the only compiler that we currently support for building the CEF binary distribution on Windows.

@magreenblatt magreenblatt reopened this Sep 27, 2024
@magreenblatt magreenblatt changed the title _HAS_EXCEPTIONS=0 is not the switch of exceptions cmake: Only define _HAS_EXCEPTIONS=0 for MSVC builds Sep 27, 2024
@magreenblatt magreenblatt added windows Windows platform Distribution Related to binary distribution enhancement Enhancement request and removed bug Bug report labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Distribution Related to binary distribution enhancement Enhancement request windows Windows platform
Projects
None yet
Development

No branches or pull requests

2 participants