[BUG]: v0 in version file for forked collection missing segment file paths from source collection

[codetheweb]

Description of changes

Prior to this fix, v0 in the version file for forked collections was missing the segment file paths from the source collection.

There was a similar bug where if segment file paths were provided during the creation of a new collection, those file paths would also be absent from v0 in the version file (we currently never provide segment file paths upon creation, but seemed good to fix as well).

Test plan

How are these changes tested?

• Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Updated existing Go integration tests to check the created version file.

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

n/a

[github-actions]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

[propel-code-bot]

Fix Missing Segment File Paths in Version File for Forked Collections

This PR fixes a bug where the v0 version file for forked collections was missing segment file paths from the source collection. It also fixes a similar issue where segment file paths provided during the creation of a new collection would be absent from v0 in the version file.

Key Changes:
• Replaced model.CreateSegment with model.Segment to ensure file paths are included
• Added code to copy segment.FilePaths when forking a collection
• Added validation in tests to verify segment file paths are properly included in version files

Affected Areas:
• go/pkg/sysdb/coordinator/
• go/pkg/sysdb/grpc/
• go/pkg/sysdb/coordinator/model/

This summary was automatically generated by @propel-code-bot

[Sicheng-Pan]

Lgtm