Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: chroma-core/chroma
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.4.19
Choose a base ref
...
head repository: chroma-core/chroma
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.4.20
Choose a head ref
  • 10 commits
  • 53 files changed
  • 4 contributors

Commits on Dec 12, 2023

  1. [ENH] Fix for record pagination (#1450)

    This fixes the pagination on records. Before we would select all data,
    and then subsample - this obviously is not very performant and this
    fixes it. credit to @HammadB
    
    
    - [x] Fix bug with limit first
    - [x] add tests
    jeffchuber authored Dec 12, 2023
    Configuration menu
    Copy the full SHA
    16d3fe9 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. [BUG] Bugfixes in auth overwrite (#1511)

    ## Description of changes
    
    *Summarize the changes made by this PR.*
     - Improvements & Bug fixes
    	 - Make sure `database` isn't `None` before reading its length.
    - Overwrite the `name` field of `CreateTenant` and `CreateDatabase`
    objects. I'm not sure the correct long-term solution here; everything I
    can think of feels pretty hacky.
    
    ## Test plan
    *How are these changes tested?*
    
    - [x] Tests pass locally with `pytest` for python, `yarn test` for js
    
    ## Documentation Changes
    *Are all docstrings for user-facing APIs updated if required? Do we need
    to make documentation changes in the [docs
    repository](https://github.com/chroma-core/docs)?*
    beggers authored Dec 13, 2023
    Configuration menu
    Copy the full SHA
    7e0df45 View commit details
    Browse the repository at this point in the history
  2. [ENH] Pagination count collections (#1451)

    Adds 2 new features
    - pagination to `list_collections` via `limit` and `offset`
    - `count_collections`
    
    Misc fixes
    - fix JS tests
    - pull TS types out and publish them
    
    TODO
    - [x] add tests for `list_collections` pagination
    - [x] add tests for `count_collections`
    jeffchuber authored Dec 13, 2023
    Configuration menu
    Copy the full SHA
    e168e93 View commit details
    Browse the repository at this point in the history
  3. [ENH] Add rust rendezvous hashing and errors (#1508)

    ## Description of changes
    
    *Summarize the changes made by this PR.*
     - Improvements & Bug fixes
    	 - /
     - New functionality
    - This adds the rendezvous hashing to the rust code so that it may be
    used by assigners.
    - It also introduces our philosophy on error handling in the rust
    codebase. We will use the 17 standard error codes in the grpc codebase,
    this is used so lower levels can send their codes higher, and in higher
    levels of the code we can Box<> a dyn Chroma Error to allow for generic
    handling over the codes. Lower levels will have to be specific, at the
    expense of verbosity in the errors they propagate and wrap. We will use
    the thiserror library, widely adopted in rust, in order to easily derive
    our errors. If a type needs to wrap a source error, thiserror provides
    #[from] in order to allow callers to have more nuanced information.
    After much research, my philosophy was informed by this post -
    https://mmapped.blog/posts/12-rust-error-handling.html.
    
    ## Test plan
    *How are these changes tested?*
    - [x] Tests pass locally with `cargo test`
    
    ## Documentation Changes
    None required. Please evaluate the documentation quality of the code
    itself.
    HammadB authored Dec 13, 2023
    Configuration menu
    Copy the full SHA
    f4e3b25 View commit details
    Browse the repository at this point in the history
  4. [ENH] Add rust assignmenment policy and config management (#1510)

    ## Description of changes
    
    *Summarize the changes made by this PR.*
     - Improvements & Bug fixes
    - Adds the `configurable` trait for static configuration of components.
    - In rust, our pattern will be that a root worker configurable object is
    consumed by components implementing the "Configurable" trait. Structs
    can then initialize themselves if the valid config exists. DI dispatch
    will happen by adding a dispatch type in the config.rs method of each
    module (not included here). Without any fancy macro programming, I think
    this is the best way to do it.
    - Calling code can `Box<dyn configurable>` and pass in the worker config
    to any components in need of configuration.
     - New functionality
    	 - Adds the rust assignment policy based on the python and go versions
    
    ## Test plan
    Added tests for booting the assignment policy config
    - [x] Tests pass locally with `cargo test`
    
    ## Documentation Changes
    None required. Feedback welcome on in-code documentation.
    HammadB authored Dec 13, 2023
    Configuration menu
    Copy the full SHA
    0bc493c View commit details
    Browse the repository at this point in the history
  5. [ENH] Add JinaEmbedding TypeScript client (#1406)

    ## Description of changes
    
    Add TypeScript client for Jina Embeddings as suggested in #1324 
    
    Docs PR: chroma-core/docs#173
    
    ---------
    
    Signed-off-by: Joan Fontanals Martinez <joan.fontanals.martinez@jina.ai>
    JoanFM authored Dec 13, 2023
    Configuration menu
    Copy the full SHA
    3939974 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Gemini (#1520)

    This adds a Google Gemini embedding function and an RAG chat example 
    
    TODO
    - [x] JS support
    - [x] Docs PR
    jeffchuber authored Dec 15, 2023
    Configuration menu
    Copy the full SHA
    99c0e9f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    240ee42 View commit details
    Browse the repository at this point in the history
  3. [Release] 0.4.20 (#1530)

    HammadB authored Dec 15, 2023
    Configuration menu
    Copy the full SHA
    3e14d25 View commit details
    Browse the repository at this point in the history
  4. release JS to 1.7.1 (#1533)

    Bump JS client to 1.7.1 to release new functionality
    - multi-tenancy
    - gemini embedding support
    jeffchuber authored Dec 15, 2023
    Configuration menu
    Copy the full SHA
    c120b5a View commit details
    Browse the repository at this point in the history
Loading