fix(walkPackageDependency): only walk dev deps for the root package

christopherthielen · christopherthielen · commit e69c3850b6d2 · 2020-05-25T15:34:23.000-07:00
diff --git a/src/packageUtils.ts b/src/packageUtils.ts
@@ -62,6 +62,8 @@ export function gatherPeerDependencies(packagePath, options: CliOptions): Depend
 }
 
 export function walkPackageDependencyTree(packagePath: string, visitor: DependencyWalkVisitor, visitedPaths: string[], options: CliOptions) {
+  const isRootPackage = visitedPaths.length === 0;
+
   if (visitedPaths.includes(packagePath)) {
     return;
   }
@@ -95,7 +97,7 @@ export function walkPackageDependencyTree(packagePath: string, visitor: Dependen
   }
 
   packageDependencies.dependencies.forEach(walkDependency);
-  packageDependencies.devDependencies.forEach(walkDependency);
+  if (isRootPackage) packageDependencies.devDependencies.forEach(walkDependency);
 }
 
 function buildDependencyArray(packagePath: string, packageJson: PackageJson, dependenciesObject: any): Dependency[] {

Original file line number	Diff line number	Diff line change
`@@ -62,6 +62,8 @@ export function gatherPeerDependencies(packagePath, options: CliOptions): Depend`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`export function walkPackageDependencyTree(packagePath: string, visitor: DependencyWalkVisitor, visitedPaths: string[], options: CliOptions) {`
	`65`	`+ const isRootPackage = visitedPaths.length === 0;`
	`66`	`+`
`65`	`67`	`if (visitedPaths.includes(packagePath)) {`
`66`	`68`	`return;`
`67`	`69`	`}`
`@@ -95,7 +97,7 @@ export function walkPackageDependencyTree(packagePath: string, visitor: Dependen`
`95`	`97`	`}`
`96`	`98`
`97`	`99`	`packageDependencies.dependencies.forEach(walkDependency);`
`98`		`- packageDependencies.devDependencies.forEach(walkDependency);`
	`100`	`+ if (isRootPackage) packageDependencies.devDependencies.forEach(walkDependency);`
`99`	`101`	`}`
`100`	`102`
`101`	`103`	`function buildDependencyArray(packagePath: string, packageJson: PackageJson, dependenciesObject: any): Dependency[] {`