Skip to content

Commit 80cc8d0

Browse files
fix(missing session expiry): fixes cases where session expiry is missing
pr: pallets-eco#57 pallets-eco#56
1 parent 9daa4a4 commit 80cc8d0

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

flask_session/sessions.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -583,7 +583,9 @@ def open_session(self, app, request):
583583
saved_session = self.sql_session_model.query.filter_by(
584584
session_id=store_id
585585
).first()
586-
if saved_session and saved_session.expiry <= datetime.utcnow():
586+
if saved_session and (
587+
not saved_session.expiry or saved_session.expiry <= datetime.utcnow()
588+
):
587589
# Delete expired session
588590
self.db.session.delete(saved_session)
589591
self.db.session.commit()

tox.ini

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ skip_install = true
3939

4040
[testenv]
4141
commands =
42-
python -m coverage run -m unittest
43-
python -m coverage report
44-
python -m coverage xml
42+
coverage run -m unittest
43+
coverage report
44+
coverage xml
45+
allowlist_externals = coverage
4546
skip_install = false

0 commit comments

Comments
 (0)