Skip to content

Commit 10ed6bc

Browse files
feat(redis): only save to redis if session is permanent
pallets-eco#80
1 parent 1c4a8ef commit 10ed6bc

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

flask_session/sessions.py

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -166,12 +166,15 @@ def save_session(self, app, session, response):
166166
if self.has_same_site_capability:
167167
conditional_cookie_kwargs["samesite"] = self.get_cookie_samesite(app)
168168
expires = self.get_expiration_time(app, session)
169-
value = self.serializer.dumps(dict(session))
170-
self.redis.setex(
171-
name=self.key_prefix + session.sid,
172-
value=value,
173-
time=total_seconds(app.permanent_session_lifetime),
174-
)
169+
170+
if session.permanent:
171+
value = self.serializer.dumps(dict(session))
172+
self.redis.setex(
173+
name=self.key_prefix + session.sid,
174+
value=value,
175+
time=total_seconds(app.permanent_session_lifetime),
176+
)
177+
175178
if self.use_signer:
176179
session_id = self._get_signer(app).sign(want_bytes(session.sid))
177180
else:

0 commit comments

Comments
 (0)