Use final whenever possible

Author: OpenRewrite

log4j-1.2-api/src/main/java/org/apache/log4j/Category.java

@@ -319,7 +319,7 @@ private void fireRemoveAppenderEvent(final Appender appender) {
         }
     }
 
-    private static Message createMessage(Object message) {
+    private static Message createMessage(final Object message) {
         if (message instanceof String) {
             return new SimpleMessage((String) message);
         }

log4j-1.2-api/src/main/java/org/apache/log4j/ConsoleAppender.java

@@ -112,7 +112,7 @@ public boolean requiresLayout() {
      *        are appended.
      * @since 1.2.13
      */
-    public void setFollow(boolean follow) {
+    public void setFollow(final boolean follow) {
         this.follow = follow;
     }
 

log4j-1.2-api/src/main/java/org/apache/log4j/FileAppender.java

@@ -74,7 +74,7 @@ public FileAppender() {
      * The file will be appended to.
      * </p>
      */
-    public FileAppender(Layout layout, String filename) throws IOException {
+    public FileAppender(final Layout layout, final String filename) throws IOException {
         this(layout, filename, true);
     }
 
@@ -86,7 +86,7 @@ public FileAppender(Layout layout, String filename) throws IOException {
      * <code>filename</code> will be truncated before being opened.
      * </p>
      */
-    public FileAppender(Layout layout, String filename, boolean append) throws IOException {
+    public FileAppender(final Layout layout, final String filename, final boolean append) throws IOException {
         this.layout = layout;
         this.setFile(filename, append, false, bufferSize);
     }
@@ -103,7 +103,7 @@ public FileAppender(Layout layout, String filename, boolean append) throws IOExc
      * file.
      * </p>
      */
-    public FileAppender(Layout layout, String filename, boolean append, boolean bufferedIO, int bufferSize) throws IOException {
+    public FileAppender(final Layout layout, final String filename, final boolean append, final boolean bufferedIO, final int bufferSize) throws IOException {
         this.layout = layout;
         this.setFile(filename, append, bufferedIO, bufferSize);
     }
@@ -194,7 +194,7 @@ protected void reset() {
      * Note: Actual opening of the file is made when {@link #activateOptions} is called, not when the options are set.
      * </p>
      */
-    public void setAppend(boolean flag) {
+    public void setAppend(final boolean flag) {
         fileAppend = flag;
     }
 
@@ -205,7 +205,7 @@ public void setAppend(boolean flag) {
      * BufferedIO will significatnly increase performance on heavily loaded systems.
      *
      */
-    public void setBufferedIO(boolean bufferedIO) {
+    public void setBufferedIO(final boolean bufferedIO) {
         this.bufferedIO = bufferedIO;
         if (bufferedIO) {
             immediateFlush = false;
@@ -215,7 +215,7 @@ public void setBufferedIO(boolean bufferedIO) {
     /**
      * Set the size of the IO buffer.
      */
-    public void setBufferSize(int bufferSize) {
+    public void setBufferSize(final int bufferSize) {
         this.bufferSize = bufferSize;
     }
 
@@ -228,10 +228,10 @@ public void setBufferSize(int bufferSize) {
      * Note: Actual opening of the file is made when {@link #activateOptions} is called, not when the options are set.
      * </p>
      */
-    public void setFile(String file) {
+    public void setFile(final String file) {
         // Trim spaces from both ends. The users probably does not want
         // trailing spaces in file names.
-        String val = file.trim();
+        final String val = file.trim();
         fileName = val;
     }
 
@@ -269,9 +269,9 @@ public synchronized void setFile(String fileName, boolean append, boolean buffer
             // attempt to create it and try to create file
             // see bug 9150
             //
-            String parentName = new File(fileName).getParent();
+            final String parentName = new File(fileName).getParent();
             if (parentName != null) {
-                File parentDir = new File(parentName);
+                final File parentDir = new File(parentName);
                 if (!parentDir.exists() && parentDir.mkdirs()) {
                     ostream = new FileOutputStream(fileName, append);
                 } else {
@@ -299,7 +299,7 @@ public synchronized void setFile(String fileName, boolean append, boolean buffer
      *
      * This method is overriden by {@link RollingFileAppender}.
      */
-    protected void setQWForFiles(Writer writer) {
+    protected void setQWForFiles(final Writer writer) {
         this.qw = new QuietWriter(writer, errorHandler);
     }
 }

log4j-1.2-api/src/main/java/org/apache/log4j/PropertyConfigurator.java

@@ -357,7 +357,7 @@ public void doConfigure(final String fileName, final LoggerRepository loggerRepo
      * @param loggerRepository The hierarchy
      */
     Configuration doConfigure(final String fileName, final LoggerRepository loggerRepository, final ClassLoader classLoader) {
-        try (InputStream inputStream = Files.newInputStream(Paths.get(fileName))) {
+        try (final InputStream inputStream = Files.newInputStream(Paths.get(fileName))) {
             return doConfigure(inputStream, loggerRepository, classLoader);
         } catch (final Exception e) {
             if (e instanceof InterruptedIOException || e instanceof InterruptedException) {
@@ -384,7 +384,7 @@ Configuration doConfigure(final URL url, final LoggerRepository loggerRepository
         LogLog.debug("Reading configuration from URL " + url);
         try {
             final URLConnection urlConnection = UrlConnectionFactory.createConnection(url);
-            try (InputStream inputStream = urlConnection.getInputStream()) {
+            try (final InputStream inputStream = urlConnection.getInputStream()) {
                 return doConfigure(inputStream, loggerRepository, classLoader);
             }
         } catch (final IOException e) {

log4j-1.2-api/src/main/java/org/apache/log4j/RenderedMessage.java

@@ -28,7 +28,7 @@ public class RenderedMessage implements Message {
     private final Object object;
     private String rendered = null;
 
-    public RenderedMessage(ObjectRenderer renderer, Object object) {
+    public RenderedMessage(final ObjectRenderer renderer, final Object object) {
         this.renderer = renderer;
         this.object = object;
     }

log4j-1.2-api/src/main/java/org/apache/log4j/RollingFileAppender.java

@@ -62,7 +62,7 @@ public RollingFileAppender() {
      * <code>filename</code> will be truncated before being opened.
      * </p>
      */
-    public RollingFileAppender(Layout layout, String filename, boolean append) throws IOException {
+    public RollingFileAppender(final Layout layout, final String filename, final boolean append) throws IOException {
         super(layout, filename, append);
     }
 
@@ -74,7 +74,7 @@ public RollingFileAppender(Layout layout, String filename, boolean append) throw
      * The file will be appended to.
      * </p>
      */
-    public RollingFileAppender(Layout layout, String filename) throws IOException {
+    public RollingFileAppender(final Layout layout, final String filename) throws IOException {
         super(layout, filename);
     }
 
@@ -113,7 +113,7 @@ void rollOver() {
         File file;
 
         if (qw != null) {
-            long size = ((CountingQuietWriter) qw).getCount();
+            final long size = ((CountingQuietWriter) qw).getCount();
             LogLog.debug("rolling over count=" + size);
             // if operation fails, do not roll again until
             // maxFileSize more bytes are written
@@ -182,10 +182,10 @@ void rollOver() {
         }
     }
 
-    public synchronized void setFile(String fileName, boolean append, boolean bufferedIO, int bufferSize) throws IOException {
+    public synchronized void setFile(final String fileName, final boolean append, final boolean bufferedIO, final int bufferSize) throws IOException {
         super.setFile(fileName, append, this.bufferedIO, this.bufferSize);
         if (append) {
-            File f = new File(fileName);
+            final File f = new File(fileName);
             ((CountingQuietWriter) qw).setCount(f.length());
         }
     }
@@ -199,7 +199,7 @@ public synchronized void setFile(String fileName, boolean append, boolean buffer
      * when it reaches <code>MaxFileSize</code>.
      * </p>
      */
-    public void setMaxBackupIndex(int maxBackups) {
+    public void setMaxBackupIndex(final int maxBackups) {
         this.maxBackupIndex = maxBackups;
     }
 
@@ -227,11 +227,11 @@ public void setMaximumFileSize(long maxFileSize) {
      * kilobytes, megabytes or gigabytes. For example, the value "10KB" will be interpreted as 10240.
      * </p>
      */
-    public void setMaxFileSize(String value) {
+    public void setMaxFileSize(final String value) {
         maxFileSize = OptionConverter.toFileSize(value, maxFileSize + 1);
     }
 
-    protected void setQWForFiles(Writer writer) {
+    protected void setQWForFiles(final Writer writer) {
         this.qw = new CountingQuietWriter(writer, errorHandler);
     }
 
@@ -240,10 +240,10 @@ protected void setQWForFiles(Writer writer) {
      *
      * @since 0.9.0
      */
-    protected void subAppend(LoggingEvent event) {
+    protected void subAppend(final LoggingEvent event) {
         super.subAppend(event);
         if (fileName != null && qw != null) {
-            long size = ((CountingQuietWriter) qw).getCount();
+            final long size = ((CountingQuietWriter) qw).getCount();
             if (size >= maxFileSize && size >= nextRollover) {
                 rollOver();
             }

log4j-1.2-api/src/main/java/org/apache/log4j/WriterAppender.java

@@ -78,7 +78,7 @@ public WriterAppender() {
      * @param layout The Layout.
      * @param os The OutputStream.
      */
-    public WriterAppender(Layout layout, OutputStream os) {
+    public WriterAppender(final Layout layout, final OutputStream os) {
         this(layout, new OutputStreamWriter(os));
     }
 
@@ -92,7 +92,7 @@ public WriterAppender(Layout layout, OutputStream os) {
      * @param layout The Layout.
      * @param writer The Writer.
      */
-    public WriterAppender(Layout layout, Writer writer) {
+    public WriterAppender(final Layout layout, final Writer writer) {
         this.layout = layout;
         this.setWriter(writer);
     }
@@ -121,7 +121,7 @@ public boolean getImmediateFlush() {
      *
      * @param value the value to set the immediate flush setting to.
      */
-    public void setImmediateFlush(boolean value) {
+    public void setImmediateFlush(final boolean value) {
         immediateFlush = value;
     }
 
@@ -145,7 +145,7 @@ public void activateOptions() {
      * layout.
      */
     @Override
-    public void append(LoggingEvent event) {
+    public void append(final LoggingEvent event) {
 
         // Reminder: the nesting of calls is:
         //
@@ -235,10 +235,10 @@ protected void closeWriter() {
      * @param os The OutputStream.
      * @return The OutputStreamWriter.
      */
-    protected OutputStreamWriter createWriter(OutputStream os) {
+    protected OutputStreamWriter createWriter(final OutputStream os) {
         OutputStreamWriter retval = null;
 
-        String enc = getEncoding();
+        final String enc = getEncoding();
         if (enc != null) {
             try {
                 retval = new OutputStreamWriter(os, enc);
@@ -260,7 +260,7 @@ public String getEncoding() {
         return encoding;
     }
 
-    public void setEncoding(String value) {
+    public void setEncoding(final String value) {
         encoding = value;
     }
 
@@ -270,7 +270,7 @@ public void setEncoding(String value) {
      * underlying {@link QuietWriter} if any.
      */
     @Override
-    public synchronized void setErrorHandler(ErrorHandler eh) {
+    public synchronized void setErrorHandler(final ErrorHandler eh) {
         if (eh == null) {
             LOGGER.warn("You have tried to set a null error-handler.");
         } else {
@@ -295,7 +295,7 @@ public synchronized void setErrorHandler(ErrorHandler eh) {
      *
      * @param writer An already opened Writer.
      */
-    public synchronized void setWriter(Writer writer) {
+    public synchronized void setWriter(final Writer writer) {
         reset();
         this.qw = new QuietWriter(writer, errorHandler);
         //this.tp = new TracerPrintWriter(qw);
@@ -312,13 +312,13 @@ public synchronized void setWriter(Writer writer) {
      *
      * @since 0.9.0
      */
-    protected void subAppend(LoggingEvent event) {
+    protected void subAppend(final LoggingEvent event) {
         this.qw.write(this.layout.format(event));
 
         if (layout.ignoresThrowable()) {
-            String[] s = event.getThrowableStrRep();
+            final String[] s = event.getThrowableStrRep();
             if (s != null) {
-                int len = s.length;
+                final int len = s.length;
                 for (int i = 0; i < len; i++) {
                     this.qw.write(s[i]);
                     this.qw.write(Layout.LINE_SEP);
@@ -360,7 +360,7 @@ protected void reset() {
      */
     protected void writeFooter() {
         if (layout != null) {
-            String f = layout.getFooter();
+            final String f = layout.getFooter();
             if (f != null && this.qw != null) {
                 this.qw.write(f);
                 this.qw.flush();
@@ -374,7 +374,7 @@ protected void writeFooter() {
      */
     protected void writeHeader() {
         if (layout != null) {
-            String h = layout.getHeader();
+            final String h = layout.getHeader();
             if (h != null && this.qw != null) {
                 this.qw.write(h);
             }

log4j-1.2-api/src/main/java/org/apache/log4j/bridge/AppenderAdapter.java

@@ -29,7 +29,7 @@
 /**
  * Binds a Log4j 1.x Appender to Log4j 2.
  */
-public class AppenderAdapter {
+public final class AppenderAdapter {
 
     private final Appender appender;
     private final Adapter adapter;
@@ -43,7 +43,7 @@ public class AppenderAdapter {
      * @param appender a Log4j 1.x appender
      * @return a Log4j 2.x appender or {@code null} if the parameter is {@code null}
      */
-    public static org.apache.logging.log4j.core.Appender adapt(Appender appender) {
+    public static org.apache.logging.log4j.core.Appender adapt(final Appender appender) {
         if (appender instanceof org.apache.logging.log4j.core.Appender) {
             return (org.apache.logging.log4j.core.Appender) appender;
         }
@@ -60,7 +60,7 @@ public static org.apache.logging.log4j.core.Appender adapt(Appender appender) {
      * Constructor.
      * @param appender The Appender to wrap.
      */
-    private AppenderAdapter(Appender appender) {
+    private AppenderAdapter(final Appender appender) {
         this.appender = appender;
         final org.apache.logging.log4j.core.Filter appenderFilter = FilterAdapter.adapt(appender.getFilter());
         String name = appender.getName();
@@ -82,7 +82,7 @@ protected Adapter(final String name, final Filter filter, final Layout<? extends
         }
 
         @Override
-        public void append(LogEvent event) {
+        public void append(final LogEvent event) {
             appender.doAppend(new LogEventAdapter(event));
         }