Skip to content

Commit ae7ff6c

Browse files
athomascommit-bot@chromium.org
authored andcommitted
[build] Set mac_use_goma_rbe to true for goma builds on mac
Without this, local builds on macOS fail to use the Goma on RBE backend. See also: https://dart-review.googlesource.com/c/sdk/+/139782 Change-Id: Ic1caba904bcb486c638aef9462bca3fda65d8a6a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152147 Reviewed-by: Karl Klose <karlklose@google.com> Commit-Queue: Alexander Thomas <athom@google.com>
1 parent bebfd10 commit ae7ff6c

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

tools/gn.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -265,6 +265,9 @@ def ToGnArgs(args, mode, arch, target_os, sanitizer, verify_sdk_hash):
265265
gn_args['use_goma'] = False
266266
gn_args['goma_dir'] = None
267267

268+
if gn_args['target_os'] == 'mac' and gn_args['use_goma']:
269+
gn_args['mac_use_goma_rbe'] = True
270+
268271
# Code coverage requires -O0 to be set.
269272
if enable_code_coverage:
270273
gn_args['dart_debug_optimization_level'] = 0

0 commit comments

Comments
 (0)