From a93ef1ab7bffbc8b02521145a3fd6c30ded7f192 Mon Sep 17 00:00:00 2001 From: Chris Bobbe Date: Tue, 31 Aug 2021 16:55:19 -0700 Subject: [PATCH] deps: Use PR branch (#328) for @react-native-community/cameraroll. Just while we wait for the code in this package to be error-free when exact_by_default is enabled [1]. We plan to enable it for the RN v0.64 upgrade (#4426). The PR is https://github.com/react-native-cameraroll/react-native-cameraroll/pull/328. It's very possible that some of those object types would be better as exact instead of inexact. But: 1. Just getting the library to pass the implicit-inexact-object lint is enough to unblock switching on exact_by_default (for us and for other projects that want to do that too). 2. I guess we could go through and decide what should stay inexact and what should be made exact. But then each of those choices would have to be approved, and some of them would probably be breaking changes that we'd need to write changelog entries for. (Not ones that would affect an app at runtime -- but still, apps that use Flow would predictably have to change their code to adapt.) [1] https://medium.com/flow-type/how-to-upgrade-to-exact-by-default-object-type-syntax-7aa44b4d08ab --- package.json | 2 +- yarn.lock | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/package.json b/package.json index 0de60781866..ea7a75715e4 100644 --- a/package.json +++ b/package.json @@ -26,7 +26,7 @@ "dependencies": { "@expo/react-native-action-sheet": "^3.8.0", "@react-native-async-storage/async-storage": "^1.13.0", - "@react-native-community/cameraroll": "^4.0.4", + "@react-native-community/cameraroll": "chrisbobbe/react-native-cameraroll#17fa5d8d2", "@react-native-community/masked-view": "^0.1.10", "@react-native-community/netinfo": "^6.0.0", "@react-native-community/push-notification-ios": "^1.5.0", diff --git a/yarn.lock b/yarn.lock index 467cfcb0b45..570f9385913 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2192,10 +2192,9 @@ dependencies: deep-assign "^3.0.0" -"@react-native-community/cameraroll@^4.0.4": +"@react-native-community/cameraroll@chrisbobbe/react-native-cameraroll#17fa5d8d2": version "4.0.4" - resolved "https://registry.yarnpkg.com/@react-native-community/cameraroll/-/cameraroll-4.0.4.tgz#3e2567ce54e3985e8e0a51832dfa0e1c5317f75b" - integrity sha512-3SY96Xh1yQjV5M7dFisl5kQmrO/K09URarZwmTN801KEalOoo/opsd/e8Vu1dwSKe0NGCK7A2u0oJQpeNbWbnA== + resolved "https://codeload.github.com/chrisbobbe/react-native-cameraroll/tar.gz/17fa5d8d2f4e00ec78304070a0b91292e884b7f5" "@react-native-community/cli-debugger-ui@^4.13.1": version "4.13.1"