Skip to content

Commit 9a502e8

Browse files
committed
lightbox header/footer: Use size prop.
Greg points out [1] that it doesn't really make sense to set the size with `fontSize`. [1] zulip#4442 (comment)
1 parent 5379c9c commit 9a502e8

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

src/lightbox/LightboxFooter.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ const styles = createStyleSheet({
2121
alignSelf: 'center',
2222
},
2323
icon: {
24-
fontSize: 28,
2524
alignSelf: 'center',
2625
},
2726
});
@@ -39,7 +38,7 @@ export default class LightboxFooter extends PureComponent<Props> {
3938
<SafeAreaView mode="padding" edges={['right', 'bottom', 'left']}>
4039
<View style={[styles.wrapper, style]}>
4140
<Text style={styles.text}>{displayMessage}</Text>
42-
<Icon style={styles.icon} color="white" name="more-vertical" onPress={onOptionsPress} />
41+
<Icon size={28} color="white" name="more-vertical" onPress={onOptionsPress} />
4342
</View>
4443
</SafeAreaView>
4544
);

src/lightbox/LightboxHeader.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,6 @@ const styles = createStyleSheet({
2727
rightIconTouchTarget: {
2828
alignSelf: 'center',
2929
},
30-
rightIcon: {
31-
fontSize: 28,
32-
},
3330
wrapper: {
3431
flex: 1,
3532
flexDirection: 'row',
@@ -74,7 +71,7 @@ export default class LightboxHeader extends PureComponent<Props> {
7471
</Text>
7572
</View>
7673
<Touchable style={styles.rightIconTouchTarget} onPress={onPressBack}>
77-
<Icon style={styles.rightIcon} color="white" name="x" />
74+
<Icon size={28} color="white" name="x" />
7875
</Touchable>
7976
</View>
8077
</SafeAreaView>

0 commit comments

Comments
 (0)