From 1af5bdbca22576491bf67e48a0143e21f5f1ba2c Mon Sep 17 00:00:00 2001 From: Chris Bobbe Date: Thu, 27 Aug 2020 14:02:04 -0700 Subject: [PATCH] ios build: Turn on "Missing Localizability" for project. Part of the RN v0.61 -> v0.62 changes to the template app [1], corresponding to facebook/react-native@ebb629d05. This is a warning we've seen for a while (#4112), and there's no suggestion that we can't do it before the main upgrade commit. This change appears in the Upgrade Support repo's official guide for how to change the Xcode files using Xcode [2]. While some of that guide is out-of-date with the actual Xcode files in the template app, this particular change is correct. [1] https://react-native-community.github.io/upgrade-helper/?from=0.61.5&to=0.62.2 [2] https://github.com/react-native-community/upgrade-support/issues/13 --- ios/ZulipMobile.xcodeproj/project.pbxproj | 4 +++- .../xcshareddata/xcschemes/ZulipMobile release-mode.xcscheme | 2 +- .../xcshareddata/xcschemes/ZulipMobile.xcscheme | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/ios/ZulipMobile.xcodeproj/project.pbxproj b/ios/ZulipMobile.xcodeproj/project.pbxproj index 6ba3579b9a1..7de1184cf66 100644 --- a/ios/ZulipMobile.xcodeproj/project.pbxproj +++ b/ios/ZulipMobile.xcodeproj/project.pbxproj @@ -175,7 +175,7 @@ 83CBB9F71A601CBA00E9B192 /* Project object */ = { isa = PBXProject; attributes = { - LastUpgradeCheck = 940; + LastUpgradeCheck = 1160; TargetAttributes = { 13B07F861A680F5B00A75B9A = { DevelopmentTeam = 66KHCWMEYB; @@ -447,6 +447,7 @@ isa = XCBuildConfiguration; buildSettings = { ALWAYS_SEARCH_USER_PATHS = NO; + CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES; CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x"; CLANG_CXX_LIBRARY = "libc++"; CLANG_ENABLE_MODULES = YES; @@ -502,6 +503,7 @@ isa = XCBuildConfiguration; buildSettings = { ALWAYS_SEARCH_USER_PATHS = NO; + CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES; CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x"; CLANG_CXX_LIBRARY = "libc++"; CLANG_ENABLE_MODULES = YES; diff --git a/ios/ZulipMobile.xcodeproj/xcshareddata/xcschemes/ZulipMobile release-mode.xcscheme b/ios/ZulipMobile.xcodeproj/xcshareddata/xcschemes/ZulipMobile release-mode.xcscheme index 0e2414f0a22..7c1f0ea05cd 100644 --- a/ios/ZulipMobile.xcodeproj/xcshareddata/xcschemes/ZulipMobile release-mode.xcscheme +++ b/ios/ZulipMobile.xcodeproj/xcshareddata/xcschemes/ZulipMobile release-mode.xcscheme @@ -1,6 +1,6 @@