Skip to content

Commit 5d2fa25

Browse files
wooster0RX14
authored andcommitted
Use double quotes in html_renderer.cr, begin_code (crystal-lang#5701)
* Use double quotes in html_renderer.cr, begin_code It should use double quotes there instead of apostrophes. Because thats generating bad html code. For example this is what glitch.com (glitch is an online html editor) says to an markdown crystal code block: https://imgur.com/a/6nUKz And other sources say too that double quotes are better. * Update markdown_spec.cr * Update markdown_spec.cr * Update markdown_spec.cr
1 parent b30a9cc commit 5d2fa25

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

spec/std/markdown/markdown_spec.cr

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ describe Markdown do
6767
assert_render " Hello\n World", "<pre><code>Hello</code></pre>\n\n<p>World</p>"
6868
assert_render " Hello\n\n\nWorld", "<pre><code>Hello</code></pre>\n\n<p>World</p>"
6969

70-
assert_render "```crystal\nHello\nWorld\n```", "<pre><code class='language-crystal'>Hello\nWorld</code></pre>"
70+
assert_render "```crystal\nHello\nWorld\n```", %(<pre><code class="language-crystal">Hello\nWorld</code></pre>)
7171
assert_render "Hello\n```\nWorld\n```", "<p>Hello</p>\n\n<pre><code>World</code></pre>"
7272
assert_render "```\n---\n```", "<pre><code>---</code></pre>"
7373

src/markdown/html_renderer.cr

+1-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ class Markdown::HTMLRenderer
5454
if language.nil?
5555
@io << "<pre><code>"
5656
else
57-
@io << "<pre><code class='language-#{language}'>"
57+
@io << %(<pre><code class="language-#{language}">)
5858
end
5959
end
6060

0 commit comments

Comments
 (0)