Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use with_transaction_result from orml-utilities #9

Open
3 tasks
islami00 opened this issue Jul 11, 2022 · 0 comments
Open
3 tasks

Use with_transaction_result from orml-utilities #9

islami00 opened this issue Jul 11, 2022 · 0 comments
Labels
difficulty: low Minimal improvement

Comments

@islami00
Copy link
Contributor

islami00 commented Jul 11, 2022 •
edited
Loading

Context

The orml-utilities crate provides us with with_transaction_result for automatically rolling back changes for extrinsics that have multiple steps that may fail after making storage writes. this is more graceful than manually rolling state back.

Todos

  • Refactor extrinsics of chocolate pallet to use with_transaction_result
  • simplify utility functions that rollback, e.g reward of ProjectIO
  • Simplify utility functions that assume all works out e.g reward_user (implemented on pallet)
@islami00 islami00 added the difficulty: low Minimal improvement label Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: low Minimal improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@islami00