Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface error more clearly for push_validity #202

Closed
kszlim opened this issue Aug 1, 2024 · 5 comments
Closed

Surface error more clearly for push_validity #202

kszlim opened this issue Aug 1, 2024 · 5 comments

Comments

@kszlim
Copy link

kszlim commented Aug 1, 2024

When this function panics, it's not clear exactly what is being pushed that violates its invariants. Ideally you'd see what arrow field is failing and what the data looks like.

@chmp
Copy link
Owner

chmp commented Aug 1, 2024

Thanks a lot for the report! The error messages are definitely something to improve.

If you have a concrete example, it would be quite helpful, so I can directly include it in the test suite.

@kszlim
Copy link
Author

kszlim commented Aug 2, 2024

I worked around the issue I encountered by mapping my schema directly, but basically the issue is that if tracing determines the schema incorrectly, there's not really a good way to determine what about the inferred schema clashes with your data that you're trying to push. You can either encounter this issue or one of the panics on the SimpleSerializer for unimplemented methods.

@chmp
Copy link
Owner

chmp commented Aug 31, 2024

My current plan is to include the relevant fields (and potentially other metadata) in the error message, e.g.,

Cannot push null for non-nullable array (field: "$.nested.field")

Would this have helped?

@kszlim
Copy link
Author

kszlim commented Sep 1, 2024

Yeah something like that would help immensely

@chmp chmp mentioned this issue Sep 1, 2024
10 tasks
@chmp
Copy link
Owner

chmp commented Sep 30, 2024

Released with 0.12.0

@chmp chmp closed this as completed Sep 30, 2024
@chmp chmp mentioned this issue Sep 30, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants