-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Add a method to directly create an arrow::RecordBatch
#132
Comments
If this is acceptable to you @chmp I would be happy to create a PR |
Hey @alamb. Thanks for the offer, in principle I would be open to an PR, but only reluctantly. To explain my reservations: due to the constant API churn I consider a larger exposure to the arrow API a risk. Initially The regular major version release is also the reason why this whole non-additive feature issue exists (at least I didn't think of a solution yet that does not involve releasing a breaking change every 6 weeks myself). |
No worries -- your explantion makes sense. I think having an example (e.g. #131) would provide 90% of the value. Maybe over time depending on how peple use the crate it would make sense to offer additional APIs, but I can see the value in keeping things simple |
Btw. the |
See also #137 |
Added a |
Released as |
Again, thank you for this library.
arrow
makes heavy use ofRecordBatch
(whilearrow2
removed the equivalent concept and deals inVec
s ofArrays
).It is possible to make
RecordBatch
from the APIs in this crate, as I demonstrate in #131, I think it would a nicer API if this crate offered a convenience method for doing so directlyHere is what you have to do today (copied from #131)
Proposal
I propose adding a
to_batch
method that coverts directly toarrow
RecordBatch:Example use:
The text was updated successfully, but these errors were encountered: