Skip to content

Make EnqIO (output of queue) IrrevocableIO, reflecting queue guarantees #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Make EnqIO (output of queue) IrrevocableIO, reflecting queue guarantees #436

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/scala/chisel3/util/Decoupled.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ object Decoupled
* Additionally, once 'valid' is raised it will never be lowered until after
* 'ready' has also been raised.
*/
class IrrevocableIO[+T <: Data](gen: T) extends ReadyValidIO[T](gen)
class IrrevocableIO[+T <: Data](gen: T) extends DecoupledIO[T](gen)
{
override def cloneType: this.type = new IrrevocableIO(gen).asInstanceOf[this.type]
}
Expand All @@ -129,7 +129,7 @@ object Irrevocable
}

object EnqIO {
def apply[T<:Data](gen: T): DecoupledIO[T] = Decoupled(gen)
def apply[T<:Data](gen: T): IrrevocableIO[T] = Irrevocable(gen)
}
object DeqIO {
def apply[T<:Data](gen: T): DecoupledIO[T] = Flipped(Decoupled(gen))
Expand Down