Make EnqIO (output of queue) IrrevocableIO, reflecting queue guarantees #436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes:
IrrevocableIOis now a subtype ofDecoupledIO, which was already assumed and implied by the documentation of the up/downconversions between them.EnqIO(the object used to create the output ofQueue) now returns an instance of typeIrrevocableIO, which reflects a guarantee provided by queues. This seems more-or-less to be central to the "queue-ness" of a module.Understandably, this creates a new burden that must be maintained in future implementations to avoid breaking the API. This enables users of
AdvTesterto use queues properly on the outputs of their designs.