From 3eaa7bc2104deef46c868a4fe4a4b32bc8b4f4b1 Mon Sep 17 00:00:00 2001 From: Vishal Khoje <36984676+vishalkhoje@users.noreply.github.com> Date: Wed, 4 Oct 2023 21:20:45 +0530 Subject: [PATCH] fix: change passkey wording Update i18n property 'Save a passkey' to 'Create a passkey' and 'Add passkey' to 'Create a passkey' in three locations: headline, button, and link, across multiple languages. --- e2e/pages/RegisterAuthenticator.ts | 4 ++-- e2e/tests/passwordless.spec.ts | 2 +- .../src/components/accordion/AddPasskeyDropdown.tsx | 2 +- frontend/elements/src/i18n/de.ts | 6 +++--- frontend/elements/src/i18n/en.ts | 6 +++--- frontend/elements/src/i18n/fr.ts | 6 +++--- frontend/elements/src/i18n/translations.ts | 2 +- frontend/elements/src/i18n/zh.ts | 6 +++--- 8 files changed, 17 insertions(+), 17 deletions(-) diff --git a/e2e/pages/RegisterAuthenticator.ts b/e2e/pages/RegisterAuthenticator.ts index 0a297060a..0b2de8225 100644 --- a/e2e/pages/RegisterAuthenticator.ts +++ b/e2e/pages/RegisterAuthenticator.ts @@ -11,12 +11,12 @@ export class RegisterAuthenticator extends BasePage { constructor(page: Page) { super(page); this.setUpPasskeyButton = page.locator("button[type=submit]", { - hasText: "Save a passkey", + hasText: "Create a passkey", }); this.skipLink = page.locator("button", { hasText: "Skip", }); - this.headline = page.locator("h1", { hasText: "Save a passkey" }); + this.headline = page.locator("h1", { hasText: "Create a passkey" }); } async registerPasskey() { diff --git a/e2e/tests/passwordless.spec.ts b/e2e/tests/passwordless.spec.ts index 162c4b2d5..66e615aeb 100644 --- a/e2e/tests/passwordless.spec.ts +++ b/e2e/tests/passwordless.spec.ts @@ -20,7 +20,7 @@ test.describe("@nopw", () => { }, }); - test(`Register, add passkey, logout, login with passkey with authenticator transport ${transport}`, async ({ + test(`Register, Create a passkey, logout, login with passkey with authenticator transport ${transport}`, async ({ loginEmailPage, registerConfirmPage, loginPasscodePage, diff --git a/frontend/elements/src/components/accordion/AddPasskeyDropdown.tsx b/frontend/elements/src/components/accordion/AddPasskeyDropdown.tsx index d302864f3..63b8530e7 100644 --- a/frontend/elements/src/components/accordion/AddPasskeyDropdown.tsx +++ b/frontend/elements/src/components/accordion/AddPasskeyDropdown.tsx @@ -62,7 +62,7 @@ const AddPasskeyDropdown = ({ return ( diff --git a/frontend/elements/src/i18n/de.ts b/frontend/elements/src/i18n/de.ts index a6675ff5b..ff3df55ef 100644 --- a/frontend/elements/src/i18n/de.ts +++ b/frontend/elements/src/i18n/de.ts @@ -8,7 +8,7 @@ export const de: Translation = { loginFinished: "Login erfolgreich", loginPasscode: "Passcode eingeben", loginPassword: "Passwort eingeben", - registerAuthenticator: "Passkey einrichten", + registerAuthenticator: "Erstellen Sie einen passkey", registerConfirm: "Konto erstellen?", registerPassword: "Neues Passwort eingeben", profileEmails: "E-Mails", @@ -76,7 +76,7 @@ export const de: Translation = { forgotYourPassword: "Passwort vergessen?", back: "Zurück", signInPasskey: "Anmelden mit Passkey", - registerAuthenticator: "Passkey einrichten", + registerAuthenticator: "Erstellen Sie einen passkey", signIn: "Anmelden", signUp: "Registrieren", sendNewPasscode: "Neuen Code senden", @@ -93,7 +93,7 @@ export const de: Translation = { newPasskeyName: "Neuer Passkey Name", addEmail: "E-Mail-Adresse hinzufügen", changePassword: "Password ändern", - addPasskey: "Passkey hinzufügen", + createPasskey: "Erstellen Sie einen passkey", webauthnUnsupported: "Passkeys werden von ihrem Browser nicht unterrstützt", signInWith: "Anmelden mit {provider}", deleteAccount: "Ja, dieses Konto löschen.", diff --git a/frontend/elements/src/i18n/en.ts b/frontend/elements/src/i18n/en.ts index bbc1d8762..2a0822230 100644 --- a/frontend/elements/src/i18n/en.ts +++ b/frontend/elements/src/i18n/en.ts @@ -8,7 +8,7 @@ export const en: Translation = { loginFinished: "Login successful", loginPasscode: "Enter passcode", loginPassword: "Enter password", - registerAuthenticator: "Save a passkey", + registerAuthenticator: "Create a passkey", registerConfirm: "Create account?", registerPassword: "Set new password", profileEmails: "Emails", @@ -74,7 +74,7 @@ export const en: Translation = { forgotYourPassword: "Forgot your password?", back: "Back", signInPasskey: "Sign in with a passkey", - registerAuthenticator: "Save a passkey", + registerAuthenticator: "Create a passkey", signIn: "Sign in", signUp: "Sign up", sendNewPasscode: "Send new code", @@ -91,7 +91,7 @@ export const en: Translation = { newPasskeyName: "New passkey name", addEmail: "Add email", changePassword: "Change password", - addPasskey: "Add passkey", + createPasskey: "Create a passkey", webauthnUnsupported: "Passkeys are not supported by your browser", signInWith: "Sign in with {provider}", deleteAccount: "Yes, delete this account.", diff --git a/frontend/elements/src/i18n/fr.ts b/frontend/elements/src/i18n/fr.ts index ad15bd99c..4d14a75e5 100644 --- a/frontend/elements/src/i18n/fr.ts +++ b/frontend/elements/src/i18n/fr.ts @@ -8,7 +8,7 @@ export const fr: Translation = { loginFinished: "Connexion réussie", loginPasscode: "Entrez le code d'accès", loginPassword: "Entrez le mot de passe", - registerAuthenticator: "Enregistrer une clé d'identification", + registerAuthenticator: "Créer une clé d'identification", registerConfirm: "Créer un compte ?", registerPassword: "Définir un nouveau mot de passe", profileEmails: "Adresses e-mail", @@ -76,7 +76,7 @@ export const fr: Translation = { forgotYourPassword: "Mot de passe oublié ?", back: "Retour", signInPasskey: "Se connecter avec une clé d'identification", - registerAuthenticator: "Enregistrer une clé d'identification", + registerAuthenticator: "Créer une clé d'identification", signIn: "Se connecter", signUp: "S'inscrire", sendNewPasscode: "Envoyer un nouveau code", @@ -93,7 +93,7 @@ export const fr: Translation = { newPasskeyName: "Nouveau nom de clé d'identification", addEmail: "Ajouter une adresse e-mail", changePassword: "Changer le mot de passe", - addPasskey: "Ajouter une clé d'identification", + createPasskey: "Créer une clé d'identification", webauthnUnsupported: "Les clés d'identification ne sont pas prises en charge par votre navigateur", signInWith: "Se connecter avec {provider}", diff --git a/frontend/elements/src/i18n/translations.ts b/frontend/elements/src/i18n/translations.ts index 5e8b74d22..ffe124038 100644 --- a/frontend/elements/src/i18n/translations.ts +++ b/frontend/elements/src/i18n/translations.ts @@ -82,7 +82,7 @@ export interface Translation { newPasskeyName: string; addEmail: string; changePassword: string; - addPasskey: string; + createPasskey: string; webauthnUnsupported: string; signInWith: string; deleteAccount: string; diff --git a/frontend/elements/src/i18n/zh.ts b/frontend/elements/src/i18n/zh.ts index ae0e8a99e..75c0b2425 100644 --- a/frontend/elements/src/i18n/zh.ts +++ b/frontend/elements/src/i18n/zh.ts @@ -8,7 +8,7 @@ export const zh: Translation = { loginFinished: "登录成功", loginPasscode: "输入验证码", loginPassword: "输入密码", - registerAuthenticator: "保存一把密钥", + registerAuthenticator: "创建密钥", registerConfirm: "创建账号？", registerPassword: "设置新密码", profileEmails: "电子邮件", @@ -68,7 +68,7 @@ export const zh: Translation = { forgotYourPassword: "忘记密码了吗？", back: "返回", signInPasskey: "使用密钥登录", - registerAuthenticator: "设置新密钥", + registerAuthenticator: "创建密钥", signIn: "登录", signUp: "注册", sendNewPasscode: "发送新代码", @@ -85,7 +85,7 @@ export const zh: Translation = { newPasskeyName: "新密钥名称", addEmail: "添加电子邮件", changePassword: "更改密码", - addPasskey: "添加密钥", + createPasskey: "创建密钥", webauthnUnsupported: "您的浏览器不支持密钥", signInWith: "通过 {provider} 登录", deleteAccount: "是的，删除此帐户。",