Skip to content

fix(context matching): Use RFC 3986 path (excludes query parameters) #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2016

Conversation

chimurai
Copy link
Owner

@chimurai chimurai commented Jun 16, 2016

fixes #86

RFC 3986 path is used for context matching. Query parameters are ignored.

This also aligns with Express http://expressjs.com/en/guide/routing.html

Query strings are not part of the route path.

@coveralls
Copy link

coveralls commented Jun 16, 2016

Coverage Status

Coverage remained the same at 99.367% when pulling 0ec0e6f on correct-wildcard-matching into 09926cd on master.

@chimurai chimurai changed the title fix(wildcard context matching): Use RFC 3986 path in wildcard match… fix(context matching): Use RFC 3986 path (excludes query parameters) Jun 16, 2016
@chimurai chimurai force-pushed the correct-wildcard-matching branch from 0ec0e6f to b942ac4 Compare June 16, 2016 19:48
@coveralls
Copy link

coveralls commented Jun 16, 2016

Coverage Status

Coverage remained the same at 99.367% when pulling b942ac4 on correct-wildcard-matching into 09926cd on master.

@chimurai chimurai force-pushed the correct-wildcard-matching branch from b942ac4 to dae53d9 Compare June 21, 2016 16:13
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.367% when pulling dae53d9 on correct-wildcard-matching into 09926cd on master.

1 similar comment
@coveralls
Copy link

coveralls commented Jun 21, 2016

Coverage Status

Coverage remained the same at 99.367% when pulling dae53d9 on correct-wildcard-matching into 09926cd on master.

@chimurai chimurai merged commit 8fe6008 into master Jun 21, 2016
@chimurai chimurai deleted the correct-wildcard-matching branch June 21, 2016 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proxy with '**' suppresses URLs with parameters
2 participants