Skip to content

Commit 47608aa

Browse files
authored
Merge pull request #409 from chimurai/refactor-e2e-tests
refactor(e2e): improve e2e tests
2 parents 7fc07a7 + 000d3b2 commit 47608aa

8 files changed

+881
-739
lines changed

package.json

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@
1515
"lint:fix": "prettier --write \"**/*.{js,ts,md}\"",
1616
"build": "tsc",
1717
"pretest": "yarn build",
18-
"test": "jest --runInBand",
18+
"test": "jest",
1919
"precover": "yarn clean && yarn build",
20-
"cover": "jest --runInBand --coverage",
20+
"cover": "jest --coverage",
2121
"precoveralls": "yarn clean && yarn build",
22-
"coveralls": "jest --runInBand --coverage --coverageReporters=text-lcov | coveralls",
22+
"coveralls": "jest --coverage --coverageReporters=text-lcov | coveralls",
2323
"postcoveralls": "yarn clean",
2424
"prepare": "yarn clean && yarn build"
2525
},
@@ -58,15 +58,18 @@
5858
"@types/lodash": "^4.14.149",
5959
"@types/micromatch": "^4.0.1",
6060
"@types/node": "^13.7.4",
61+
"@types/supertest": "^2.0.8",
6162
"browser-sync": "^2.26.7",
6263
"connect": "^3.7.0",
6364
"coveralls": "^3.0.5",
6465
"express": "^4.17.1",
6566
"husky": "^4.2.3",
6667
"jest": "^25.1.0",
6768
"lint-staged": "^10.0.7",
69+
"mockttp": "^0.19.3",
6870
"open": "^7.0.2",
6971
"prettier": "^1.19.1",
72+
"supertest": "^4.0.2",
7073
"ts-jest": "^25.2.0",
7174
"tslint": "^6.0.0",
7275
"tslint-config-prettier": "^1.18.0",

test/e2e/_utils.ts

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,14 @@ import * as express from 'express';
22

33
export { createProxyMiddleware } from '../../dist/index';
44

5-
export function createServer(portNumber, middleware, path?) {
5+
export function createApp(middleware) {
66
const app = express();
7+
app.use(middleware);
8+
return app;
9+
}
710

8-
if (middleware && path) {
9-
app.use(path, middleware);
10-
} else if (middleware) {
11-
app.use(middleware);
12-
}
13-
14-
const server = app.listen(portNumber);
15-
16-
return server;
11+
export function createAppWithPath(path, middleware) {
12+
const app = express();
13+
app.use(path, middleware);
14+
return app;
1715
}

0 commit comments

Comments
 (0)