From 5fb7b0cff005f2262c24ec6b6b7ccf2189b556e2 Mon Sep 17 00:00:00 2001 From: Alexander Sklar Date: Mon, 28 Mar 2022 10:07:42 -0700 Subject: [PATCH] feat(windows): Add WebView2 UWP Desktop support (#2419) * feat(windows): Add WebView2 UWP Desktop support * remove expired cert * deploy from layout in ci --- .github/workflows/windows-ci.yml | 4 ++-- example/app.json | 4 +--- example/windows/WebViewWindows_TemporaryKey.pfx | Bin 2520 -> 0 bytes .../ReactNativeWebView.vcxproj | 1 + 4 files changed, 4 insertions(+), 5 deletions(-) delete mode 100644 example/windows/WebViewWindows_TemporaryKey.pfx diff --git a/.github/workflows/windows-ci.yml b/.github/workflows/windows-ci.yml index f9fc44f1b..d56326a0a 100644 --- a/.github/workflows/windows-ci.yml +++ b/.github/workflows/windows-ci.yml @@ -42,13 +42,13 @@ jobs: run: yarn windows --release --no-packager --no-deploy --logging # Workaround for a bug in package searching during deploy. - # The deploy script only searches windows/{*/bin/x64/Release,Release/*}, but the build step above placed the pakcages at windows/x64/Release. + # The deploy script only searches windows/{*/bin/x64/Release,Release/*}, but the build step above placed the packages at windows/x64/Release. # Copy the packages to Windows/Release before deploying. - name: Deploy shell: powershell run: | Copy-Item -Path example\windows\x64\Release -Recurse -Destination example\windows\ - npx react-native run-windows --arch x64 --release --root example --logging --no-build --no-packager + npx react-native run-windows --arch x64 --release --root example --logging --no-build --no-packager --deploy-from-layout - name: Start Appium server shell: powershell diff --git a/example/app.json b/example/app.json index 02f46848f..e9f9c4434 100644 --- a/example/app.json +++ b/example/app.json @@ -26,8 +26,6 @@ ] }, "windows": { - "appxManifest": "windows/Package.appxmanifest", - "certificateKeyFile": "windows/WebViewWindows_TemporaryKey.pfx", - "certificateThumbprint": "1DA6E34911B18C433FE3E543D0429FC808468C89" + "appxManifest": "windows/Package.appxmanifest" } } diff --git a/example/windows/WebViewWindows_TemporaryKey.pfx b/example/windows/WebViewWindows_TemporaryKey.pfx deleted file mode 100644 index 6d1279f0f18fce7d0ead815d5a348665bda2d768..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 2520 zcmZWqcU05a68;59LO^;`K}tlbETKe@w$h7$RH-UekS+v~rAd^c5Q?yh1_2f69i$Ti zibykrW;B!lQiMcMU|k~R{oM1O@4WNQJ#+6j-^@32|G9HfSi}SigcXHFWWf*$$!5vl zxgc;z5f+iihDF4IbTkSJW&TeHy3U4$u7LC+Xmc>mf2)pgKv;^fYzHVT8xti4i3thSTCbrXi>VR4L9u4 zVwsyJA!-pmbInoes>_>Yn$1#wRKQQ%4)zdT=`rcJ%iVZ zr9P`Vm_x(XhI(e|mFge6wtu2G^I;cGU#~yB(_A}HK<$a|*?FV1<9CMFcw_pcYp?L^ z6eD_It%6&d;lkq~&5t)vlJ&@N3BOo|vI^R4QPV!TL{U*6yd7Z38BrWSjuc$H#n4Pb zl3P{3H;t6Dn^~P+?tLjI3$cOGUZ<}8L5`KtT@AkJ)sg3#bK3xsWg0=5yUPvlQ(JWr z2}Xy({YB^XOx8(oYfbvg^zV{;Zdy_v-fnTb_S1FeswFY67Bdy}cAn$+Z7T9zE)IMN zOfVf`dUsA;Zd5ZeDL$h&`T{Qw+}zM?uUcHgz0E$#t?kdZP2e6@)Auj71`0STBxDz` z_q81O;eFoL7|m>gPJ*zGV7^pf2Yl&N6|IjzoZ2y*GUjuxKl5twyM8~{muxrdgz75_SI$M9?aFF6Q(a>}6w(h>Q>y&tT z*Zz>tSDQr*XBNnSvU&HKoTtrY^YVVm0^eD0he?0iaDmKe6D{YgpexQ?_FEZc{71K5 zPg%qCuBP|5PG*+eRg(k)1wH1ApP7(uj-I%TAW9#Vj5Bg(!8^j3_w)vNmH6+o{xQ+X zR~cxw*ZR@Eb*3>!U#5R2vRI2Tj<6tE7y3F>>e^O~C(dmDU|t$wc8k*J=BAFrE;O$0DJp`pj`zpfFxiK?mw9jzz_5cK^zT)fm|r)hl7Q~0RMkfl7P)Wc{f1M2W%aV z!m>vFx;Y$Hgk|*yDIXRH03KlLUth-mkNndLzTY$`_>G?<{}z@N1rZ-ymb#Xg)iWDULXG<#MDE`}vhQ_=-#~QVwVMqvL*h^vx{D zSB1Oh`rgrpy7Pn8FZhcR8XM)Y4jr3nS>Bmf!WR*2M_f7Hgvn^;{8ZG!9 zDP&wsUp+c26IM2nxI8e4*{2JzqC=EY)`=o%hN)Z_+cSD*d{bfNKS4opzRf@e);* zT^T$M&rYewFK5t`*#$>6uoWFwihxu*~_eGP+w3xcU92_dUt4$(W!iG`u>)%&6b zkmx%J4rQ_YD;4HlRG}RGm7~@&qb-+ zJAAGb!sSCbN4gsv)P4J$9(9;p zycoS6Xy(t_di?Sye?9j!+fb+Z2)n;0XHw*yvy)ooYp(?@xBuCpcz(8f@g93?)Rq1p zZ;2lVTK1o&<7r|lY0v-4qKj+i-IiEhE0O!C`u4JkYhg;K_%2o1$&|%?jG00Vbyn~{ zTz`C}R`ZfYCr`;p<*aWF^!ghIDvey?;aorYIAybV!n9W-Npvr8irk(kVnB~C_nSr> zaqOq(nd+3;4r8nH!I6=Ho@LEr`Gu@^jsc( oq-m%|J}gnF={92%47g>uwVHf7BiY9=U4B5=l0Ss@=g$ZCFXiHlmjD0& diff --git a/windows/ReactNativeWebView/ReactNativeWebView.vcxproj b/windows/ReactNativeWebView/ReactNativeWebView.vcxproj index d74711f50..5213cc011 100644 --- a/windows/ReactNativeWebView/ReactNativeWebView.vcxproj +++ b/windows/ReactNativeWebView/ReactNativeWebView.vcxproj @@ -147,6 +147,7 @@ +