Skip to content

Commit 646b67d

Browse files
davidhildenbrandakpm00
authored andcommitted
mm/memremap: reject unreasonable folio/compound page sizes in memremap_pages()
Let's reject unreasonable folio sizes early, where we can still fail. We'll add sanity checks to prepare_compound_head/prepare_compound_page next. Is there a way to configure a system such that unreasonable folio sizes would be possible? It would already be rather questionable. If so, we'd probably want to bail out earlier, where we can avoid a WARN and just report a proper error message that indicates where something went wrong such that we messed up. Link: https://lkml.kernel.org/r/20250901150359.867252-8-david@redhat.com Signed-off-by: David Hildenbrand <david@redhat.com> Acked-by: SeongJae Park <sj@kernel.org> Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com> Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 0bf2edf commit 646b67d

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

mm/memremap.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -275,6 +275,9 @@ void *memremap_pages(struct dev_pagemap *pgmap, int nid)
275275

276276
if (WARN_ONCE(!nr_range, "nr_range must be specified\n"))
277277
return ERR_PTR(-EINVAL);
278+
if (WARN_ONCE(pgmap->vmemmap_shift > MAX_FOLIO_ORDER,
279+
"requested folio size unsupported\n"))
280+
return ERR_PTR(-EINVAL);
278281

279282
switch (pgmap->type) {
280283
case MEMORY_DEVICE_PRIVATE:

0 commit comments

Comments
 (0)