Skip to content

Commit 32f36bc

Browse files
rddunlapgregkh
authored andcommitted
serial: 8250: ASPEED_VUART: select REGMAP instead of depending on it
commit f8086d1 upstream. REGMAP is a hidden (not user visible) symbol. Users cannot set it directly thru "make *config", so drivers should select it instead of depending on it if they need it. Consistently using "select" or "depends on" can also help reduce Kconfig circular dependency issues. Therefore, change the use of "depends on REGMAP" to "select REGMAP". Fixes: 8d310c9 ("drivers/tty/serial/8250: Make Aspeed VUART SIRQ polarity configurable") Cc: stable <stable@kernel.org> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Oskar Senft <osk@google.com> Cc: linux-serial@vger.kernel.org Link: https://lore.kernel.org/r/20230226053953.4681-9-rdunlap@infradead.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent f0ff9d2 commit 32f36bc

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/tty/serial/8250/Kconfig

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,8 +253,9 @@ config SERIAL_8250_ASPEED_VUART
253253
tristate "Aspeed Virtual UART"
254254
depends on SERIAL_8250
255255
depends on OF
256-
depends on REGMAP && MFD_SYSCON
256+
depends on MFD_SYSCON
257257
depends on ARCH_ASPEED || COMPILE_TEST
258+
select REGMAP
258259
help
259260
If you want to use the virtual UART (VUART) device on Aspeed
260261
BMC platforms, enable this option. This enables the 16550A-

0 commit comments

Comments
 (0)