Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UTF-8 string directly instead of hex string #24

Open
czchen opened this issue Mar 2, 2014 · 3 comments
Open

Use UTF-8 string directly instead of hex string #24

czchen opened this issue Mar 2, 2014 · 3 comments
Labels

Comments

@czchen
Copy link
Member

czchen commented Mar 2, 2014

Hex string is used for UTF-8 string due to Visual Studio. However, according to this, we can use #pragma execution_character_set("utf-8") to let Visual Studio uses UTF-8 encoding. In this way, we might be able to avoid ugly hex string.

@czchen czchen added this to the 0.0.1 milestone Mar 2, 2014
@czchen czchen added the feature label Mar 2, 2014
@czchen
Copy link
Member Author

czchen commented Mar 3, 2014

Need to test in Windows.

@czchen
Copy link
Member Author

czchen commented Nov 5, 2014

See #37. Currently we cannot build chewing-editor in Windows due to C++11 features.

@czchen czchen removed this from the 0.0.1 milestone Nov 5, 2014
@Chocobo1
Copy link
Member

I've encountered this bug before (in qBittorrent).
The solution ended up moving all UTF8 strings to a file and encode the file with UTF-8 (with BOM) and also adding the #pragma.
See: https://github.com/qbittorrent/qBittorrent/blob/master/src/base/unicodestrings.h

If you find this solution acceptable, I can help implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants