sudo chef-server-ctl user-create shouldn't show the key in the terminal

[tas50]

Chef Server Version

13.0

Platform Details

Ubuntu 18.04

Configuration

Standalone

Scenario:

When the user runs 'sudo chef-server-ctl user-create ...' it currently creates the private key in the terminal. This means the private key is available in terminal scrollback which can be infinite for a lot of users. This seems like a bad security setup. We should just write the key to disk and then tell the user where to find it. That's how a lot of similar CLI tools handle key generation so they don't save secrets into insecure mediums.

[kaorihinata]

Probably worth mentioning that chef-server-ctl actually wraps knife-opc to provide most of its organizational management functionality. It also wraps it pretty closely (see: wrap-knife-opc.rb), so there's not really much room to override this functionality in chef-server-ctl. You may want to move this issue over to knife-opc.