feat: handle disabled state better

Author: scmmishra

lib/agents/tracing.rb

@@ -26,10 +26,15 @@ module Tracing
     class << self
       # Initialize OpenTelemetry SDK with OTLP exporter.
       # Called automatically during Agents.configure if tracing is enabled.
+      # If tracing is disabled, tears down any existing tracing infrastructure.
       #
       # @param config [Agents::Configuration] The configuration object
       def setup(config)
-        return unless config.enable_tracing
+        unless config.enable_tracing
+          # Explicitly disable tracing if it was previously enabled
+          teardown if @enabled
+          return
+        end
 
         # Configure the OTLP exporter
         exporter = OpenTelemetry::Exporter::OTLP::Exporter.new(
@@ -187,13 +192,21 @@ def tool_span(tool_name, arguments:, attributes: {})
       # Reset tracing state (mainly for testing)
       # @private
       def reset!
+        teardown
+      end
+
+      private
+
+      # Tear down tracing infrastructure
+      # Clears internal state but does not shutdown the OpenTelemetry tracer provider
+      # (which is a global singleton and cannot be reinitialized in the same process).
+      # @private
+      def teardown
         @tracer = nil
         @enabled = false
         Thread.current[:agents_trace_context_stack] = nil
       end
 
-      private
-
       # Thread-local storage for trace context stack
       def trace_context_stack
         Thread.current[:agents_trace_context_stack] ||= []

spec/agents/tracing_spec.rb

@@ -41,6 +41,25 @@
         expect(described_class.enabled?).to be false
       end
     end
+
+    context "when reconfiguring" do
+      let(:disabled_config) do
+        instance_double(
+          Agents::Configuration,
+          enable_tracing: false
+        )
+      end
+
+      it "disables tracing when reconfigured with enable_tracing: false" do
+        # First enable tracing
+        described_class.setup(config)
+        expect(described_class.enabled?).to be true
+
+        # Then disable it
+        described_class.setup(disabled_config)
+        expect(described_class.enabled?).to be false
+      end
+    end
   end
 
   describe ".with_trace" do