Skip to content

Allow fill: true and null in ChartDataset.data #8700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2021
Merged

Allow fill: true and null in ChartDataset.data #8700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e3ffec
Handle `fill: true`
etimberg Mar 22, 2021
1dba63a
ChartDataset allow number/null data
etimberg Mar 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions types/index.esm.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1966,7 +1966,7 @@ export interface FillerOptions {
propagate: boolean;
}

export type FillTarget = number | string | { value: number } | 'start' | 'end' | 'origin' | 'stack' | false;
export type FillTarget = number | string | { value: number } | 'start' | 'end' | 'origin' | 'stack' | boolean;

export interface ComplexFillTarget {
/**
Expand Down Expand Up @@ -3207,14 +3207,14 @@ export interface ChartTypeRegistry {
line: {
chartOptions: LineControllerChartOptions;
datasetOptions: LineControllerDatasetOptions & FillerControllerDatasetOptions;
defaultDataPoint: ScatterDataPoint;
defaultDataPoint: ScatterDataPoint | number | null;
parsedDataType: CartesianParsedData;
scales: keyof CartesianScaleTypeRegistry;
};
scatter: {
chartOptions: ScatterControllerChartOptions;
datasetOptions: ScatterControllerDatasetOptions;
defaultDataPoint: ScatterDataPoint;
defaultDataPoint: ScatterDataPoint | number | null;
parsedDataType: CartesianParsedData;
scales: keyof CartesianScaleTypeRegistry;
};
Expand Down Expand Up @@ -3249,7 +3249,7 @@ export interface ChartTypeRegistry {
radar: {
chartOptions: RadarControllerChartOptions;
datasetOptions: RadarControllerDatasetOptions;
defaultDataPoint: number;
defaultDataPoint: number | null;
parsedDataType: RadialParsedData;
scales: keyof RadialScaleTypeRegistry;
};
Expand Down
16 changes: 16 additions & 0 deletions types/tests/dataset_null_data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import { ChartDataset } from '../index.esm';

const dataset: ChartDataset = {
data: [10, null, 20],
};

const lineDataset: ChartDataset<'line'> = {
data: [10, null, 20],
};
const scatterDataset: ChartDataset<'scatter'> = {
data: [10, null, 20],
};
const radarDataset: ChartDataset<'radar'> = {
data: [10, null, 20],
};

6 changes: 6 additions & 0 deletions types/tests/plugins/plugin.filler/fill_target_true.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import { ChartDataset } from '../../../index.esm';

const dataset: ChartDataset = {
data: [],
fill: true,
};