Skip to content

Stop reading fixedStepSize from tick options #8466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2021
Merged

Stop reading fixedStepSize from tick options #8466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/docs/getting-started/v3-migration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ Animation system was completely rewritten in Chart.js v3. Each property can now
#### Ticks

* `options.gridLines.tickMarkLength` was renamed to `options.gridLines.tickLength`.
* `options.ticks.fixedStepSize` is no longer used. Use `options.ticks.stepSize`.
* `options.ticks.major` and `options.ticks.minor` were replaced with scriptable options for tick fonts.
* `Chart.Ticks.formatters.linear` was renamed to `Chart.Ticks.formatters.numeric`.

Expand Down
4 changes: 2 additions & 2 deletions src/scales/scale.linearbase.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {isNullOrUndef, valueOrDefault} from '../helpers/helpers.core';
import {isNullOrUndef} from '../helpers/helpers.core';
import {almostEquals, almostWhole, log10, _decimalPlaces, _setMinAndMaxByKey, sign} from '../helpers/helpers.math';
import Scale from '../core/core.scale';
import {formatNumber} from '../core/core.intl';
Expand Down Expand Up @@ -200,7 +200,7 @@ export default class LinearScaleBase extends Scale {
min: opts.min,
max: opts.max,
precision: tickOpts.precision,
stepSize: valueOrDefault(tickOpts.fixedStepSize, tickOpts.stepSize)
stepSize: tickOpts.stepSize
};
const ticks = generateTicks(numericGeneratorOptions, me);

Expand Down