Improved financial sample #6998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
force-pushed
the
advanced-financial
branch
2 times, most recently
from
ee97a5b to
0c685b1
Compare
benmccann
force-pushed
the
advanced-financial
branch
from
0c685b1 to
823e244
Compare
kurkle
requested changes
Jan 22, 2020
kurkle
approved these changes
Jan 26, 2020
etimberg
approved these changes
Jan 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd be fine closing #6791 since it seems controversial. Instead perhaps we should add to the performance docs that
source === 'data' || (source === 'auto' && options.distribution === 'series')may be slow, so you may want to generate your own ticks with a faster method. This improves the speed of the financial sample in that vein. Before it just did it's own logic to determine the major ticks, but now it generates the ticks from scratch in a faster mannerWe could also consider reverting the changes to
generatefrom #6509 so that ticks are generated further apart or using @kurkle's new branch which does that as well. I'd like to keep the scriptable tick options andsampleSizeoption thoughI moved the sample from "Scales" to "Advanced" since it was already pretty advanced and this makes it even more so. I'd have probably put it there originally, but that wasn't a section that existed at the time
This also fixes the bug @kurkle found today: (the picture below shows the bug)