-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inject styles into Shadow DOM when inside Shadow DOM (#5763) #6556
Inject styles into Shadow DOM when inside Shadow DOM (#5763) #6556
Conversation
Looks good! Can you add a test pen where the functionality can be verified? (Fork https://stackblitz.com/edit/polymer310-testcase-chartjs for example) |
Thanks @kurkle. I'm not sure what's up with the error I'm getting when using https://stackblitz.com/edit/polymer310-testcase-chartjs-zxndkp I copied my exact testing page into
If any reviewer has the patience to help out with this I would appreciate it a lot! I'm not really sure if I'm missing something obvious to make this work. However I would expect the pen you linked (https://stackblitz.com/edit/polymer310-testcase-chartjs) to also work with the changes in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working test case:
https://stackblitz.com/edit/polymer310-testcase-chartjs-avhczw
<style>
used by ChartJS intodocument.head
and each Shadow Root as needednode[EXPANDO]: { containsStyles: boolean }
todocument.head
and each Shadow Root that contains a ChartJS instanceplatform._style
andplatform._loaded
since we now need to keep track of multiple<style>
insertionsTo-do(?):
<script>
inside Shadow DOMs in the case ofdisableCSSInjection: true
- example workaroundCloses: #5763