Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache getScaleForId() calls in the line controller #6250

Merged
merged 1 commit into from
May 8, 2019
Merged

Cache getScaleForId() calls in the line controller #6250

merged 1 commit into from
May 8, 2019

Conversation

benmccann
Copy link
Contributor

Minor performance improvement. Saves two calls to getMeta and three to getScaleForId for each data point

kurkle
kurkle approved these changes May 7, 2019
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good little optimization.
Couple of bytes could be saved more, but those might be worth wasting for readability. I'm ok either way.

src/controllers/controller.line.js Show resolved Hide resolved
@simonbrunel simonbrunel added this to the Version 2.9 milestone May 8, 2019
@simonbrunel simonbrunel merged commit f093c36 into chartjs:master May 8, 2019
@simonbrunel simonbrunel changed the title Cache scales Cache getScaleForId() calls in the line controller May 8, 2019
@snyk-bot snyk-bot mentioned this pull request Nov 9, 2019
Merged
This was referenced Mar 4, 2020
Open
Open
@vpetersson vpetersson mentioned this pull request Mar 7, 2020
Merged
This was referenced Mar 9, 2020
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
This was referenced Apr 14, 2020
Open
Open
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
@benmccann @simonbrunel
Cache getScaleForId() calls in the line controller (chartjs#6250)
fb7e8ae
This was referenced Jun 1, 2021
Closed
Merged
Closed
Open
Closed
Open
Open
This was referenced Jul 5, 2021
Closed
Open
This was referenced Jul 27, 2021
Closed
Merged
Merged
This was referenced Oct 14, 2021
Merged
Closed
@jw jw mentioned this pull request Jan 17, 2022
Open
1 task
This was referenced Jan 21, 2022
Merged
Closed
This was referenced Feb 4, 2022
Closed
Closed
This was referenced Mar 7, 2022
Open
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Aug 13, 2022
Merged
1 task
This was referenced Nov 29, 2022
Closed
Closed
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jan 26, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

@etimberg etimberg etimberg approved these changes

@nagix nagix nagix approved these changes

Assignees
No one assigned
Labels
type: chore
Projects
None yet
Milestone
Version 2.9
Development

Successfully merging this pull request may close these issues.
5 participants
@benmccann @nagix @etimberg @kurkle @simonbrunel