Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement layers (z-index) for layout items #6241

Merged
merged 4 commits into from
May 9, 2019
Merged

Implement layers (z-index) for layout items #6241

merged 4 commits into from
May 9, 2019

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented May 4, 2019

Allow changing of drawing order by z-index. Option available for gridLines and ticks initially.

Demo

Alternative to: #6226

Closes: #2808
Closes: #3724
Closes: #3738
Closes: #3722
Closes: #3957

@simonbrunel simonbrunel changed the title Layers (z-index) Implement layers (z-index) for layout items May 4, 2019
@benmccann
Copy link
Contributor

Cool idea! I'd probably call it zIndex rather than just z, but curious what other think about the naming

@simonbrunel
Copy link
Member

I prefer z since I don't think of any other use for that option name and usually prefer shorter names (I'm also familiar with z in QML).

@simonbrunel simonbrunel requested review from nagix and etimberg May 6, 2019 20:46
etimberg
etimberg previously approved these changes May 7, 2019
View reviewed changes
nagix
nagix reviewed May 7, 2019
View reviewed changes
Copy link
Contributor

@nagix nagix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, Looks good.

test/fixtures/scale.radialLinear/gridlines-no-z.json Outdated Show resolved Hide resolved
src/scales/scale.radialLinear.js Outdated Show resolved Hide resolved
@nagix nagix mentioned this pull request May 7, 2019
Closed
benmccann
benmccann reviewed May 8, 2019
View reviewed changes
src/core/core.scale.js Outdated Show resolved Hide resolved
benmccann
benmccann previously approved these changes May 8, 2019
View reviewed changes
@kurkle
Copy link
Member Author

kurkle commented May 8, 2019

Cool idea!

You have to thank @simonbrunel for the idea 👍

@simonbrunel simonbrunel added this to the Version 2.9 milestone May 9, 2019
@simonbrunel simonbrunel merged commit 2a96d83 into chartjs:master May 9, 2019
@kurkle kurkle mentioned this pull request May 9, 2019
Closed
@benmccann benmccann mentioned this pull request May 11, 2019
Closed
@SimonCraenen
Copy link

When will this be released?

@jbee
Copy link

jbee commented Sep 20, 2019

Waiting for the feature as well.

@snyk-bot snyk-bot mentioned this pull request Nov 9, 2019
Merged
This was referenced Apr 14, 2020
Open
Open
@juliankigwana juliankigwana mentioned this pull request Nov 13, 2020
Closed
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
@kurkle @simonbrunel
Implement layers (z-index) for layout items (chartjs#6241)
9117b98
This was referenced Jun 1, 2021
Closed
Merged
Closed
Open
Closed
Open
Open
This was referenced Jul 5, 2021
Closed
Open
This was referenced Jul 27, 2021
Closed
Merged
Merged
This was referenced Oct 14, 2021
Merged
Closed
@jw jw mentioned this pull request Jan 17, 2022
Open
1 task
This was referenced Jan 21, 2022
Merged
Closed
This was referenced Feb 4, 2022
Closed
Closed
This was referenced Mar 7, 2022
Open
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Aug 13, 2022
Merged
1 task
This was referenced Nov 29, 2022
Closed
Closed
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jan 26, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@simonbrunel simonbrunel simonbrunel approved these changes

@nagix nagix nagix approved these changes

@benmccann benmccann benmccann approved these changes

Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
Version 2.9
7 participants
@kurkle @benmccann @simonbrunel @SimonCraenen @jbee @nagix @etimberg