Skip to content

Change readme and docs on bundled version #5528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
etimberg merged 1 commit into from
Jun 4, 2018
Merged

Change readme and docs on bundled version #5528

etimberg merged 1 commit into from
Jun 4, 2018

Conversation

@gdvalderrama
Copy link
Contributor

@gdvalderrama gdvalderrama commented May 29, 2018

Clarifying Moment.js included in bundle as suggested in #5236

@gdvalderrama gdvalderrama changed the title clarify moment.js included in bundle cannot be used outside of chartjs Change readme and docs on bundled version May 29, 2018
@gdvalderrama gdvalderrama mentioned this pull request May 29, 2018
Closed
@etimberg etimberg requested a review from simonbrunel May 30, 2018 01:16
@etimberg etimberg added this to the Version 2.8 milestone May 30, 2018
@simonbrunel simonbrunel requested a review from etimberg May 30, 2018 06:11
simonbrunel
simonbrunel approved these changes May 30, 2018
View reviewed changes
Copy link
Member

@simonbrunel simonbrunel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gdvalderrama

@simonbrunel simonbrunel requested a review from benmccann May 30, 2018 06:12
@etimberg etimberg merged commit 8a72780 into chartjs:master Jun 4, 2018
@vpetersson vpetersson mentioned this pull request Mar 7, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 9, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
@gdvalderrama @etimberg
clarify moment.js included in bundle cannot be used outside of chartjs (
5d45282 
chartjs#5528)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonbrunel simonbrunel simonbrunel approved these changes

@etimberg etimberg Awaiting requested review from etimberg

+1 more reviewer

@benmccann benmccann benmccann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type: documentation

Projects

None yet

Milestone

Version 2.7.3

Development

Successfully merging this pull request may close these issues.

4 participants

@gdvalderrama @benmccann @simonbrunel @etimberg