Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rewrite canvas helpers to ts #11100

Merged
merged 3 commits into from
Feb 15, 2023
Merged

refactor: rewrite canvas helpers to ts #11100

merged 3 commits into from
Feb 15, 2023

Conversation

dangreen
Copy link
Collaborator

No description provided.

@LeeLenaleee LeeLenaleee added type: enhancement type: types Typescript type changes labels Jan 30, 2023
@LeeLenaleee LeeLenaleee added this to the Version 4.3.0 milestone Jan 30, 2023
LeeLenaleee
LeeLenaleee previously approved these changes Jan 30, 2023
Copy link
Member

@etimberg etimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment

src/helpers/helpers.canvas.ts Outdated Show resolved Hide resolved
etimberg
etimberg previously approved these changes Feb 2, 2023
LeeLenaleee
LeeLenaleee previously approved these changes Feb 2, 2023
kurkle
kurkle previously approved these changes Feb 3, 2023
src/helpers/types.ts Outdated Show resolved Hide resolved
etimberg
etimberg previously approved these changes Feb 7, 2023
@etimberg
Copy link
Member

@kurkle @LeeLenaleee do you want to review this further?

LeeLenaleee
LeeLenaleee previously approved these changes Feb 10, 2023
kurkle
kurkle previously approved these changes Feb 12, 2023
@etimberg
Copy link
Member

Looks like this has a conflict that needs resolving

@dangreen dangreen dismissed stale reviews from kurkle, LeeLenaleee, and etimberg via 4eee2b3 February 13, 2023 10:54
@dangreen
Copy link
Collaborator Author

@etimberg ready to merge

@etimberg etimberg merged commit 1324672 into chartjs:master Feb 15, 2023
@dangreen dangreen deleted the refactor-canvas-helpers branch February 17, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement type: types Typescript type changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants