Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rewrite canvas helpers to ts #11100

Merged
merged 3 commits into from
Feb 15, 2023
Merged

refactor: rewrite canvas helpers to ts #11100

merged 3 commits into from
Feb 15, 2023

Conversation

dangreen
Copy link
Collaborator

No description provided.

@LeeLenaleee LeeLenaleee added type: enhancement type: types Typescript type changes labels Jan 30, 2023
@LeeLenaleee LeeLenaleee added this to the Version 4.3.0 milestone Jan 30, 2023
LeeLenaleee
LeeLenaleee previously approved these changes Jan 30, 2023
View reviewed changes
etimberg
etimberg reviewed Jan 31, 2023
View reviewed changes
Copy link
Member

@etimberg etimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment

src/helpers/helpers.canvas.ts Outdated Show resolved Hide resolved
@dangreen dangreen mentioned this pull request Jan 31, 2023
Open
etimberg
etimberg previously approved these changes Feb 2, 2023
View reviewed changes
LeeLenaleee
LeeLenaleee previously approved these changes Feb 2, 2023
View reviewed changes
kurkle
kurkle previously approved these changes Feb 3, 2023
View reviewed changes
src/helpers/types.ts Outdated Show resolved Hide resolved
@dangreen dangreen dismissed stale reviews from kurkle, LeeLenaleee, and etimberg via 56329b5 February 6, 2023 19:15
etimberg
etimberg previously approved these changes Feb 7, 2023
View reviewed changes
@etimberg
Copy link
Member

@kurkle @LeeLenaleee do you want to review this further?

LeeLenaleee
LeeLenaleee previously approved these changes Feb 10, 2023
View reviewed changes
kurkle
kurkle previously approved these changes Feb 12, 2023
View reviewed changes
@etimberg
Copy link
Member

Looks like this has a conflict that needs resolving

@dangreen dangreen dismissed stale reviews from kurkle, LeeLenaleee, and etimberg via 4eee2b3 February 13, 2023 10:54
@dangreen
Copy link
Collaborator Author

@etimberg ready to merge

@etimberg etimberg merged commit 1324672 into chartjs:master Feb 15, 2023
@dangreen dangreen deleted the refactor-canvas-helpers branch February 17, 2023 09:13
@raymondhtet raymondhtet mentioned this pull request May 29, 2024
Closed
@wanissr wanissr mentioned this pull request Jun 22, 2024
Open
@bwilliford bwilliford mentioned this pull request Jun 26, 2024
Open
@raymondhtet raymondhtet mentioned this pull request Jul 5, 2024
Closed
@raymondhtet raymondhtet mentioned this pull request Jul 14, 2024
Closed
@faragashraf faragashraf mentioned this pull request Jul 18, 2024
Open
@mytamDo mytamDo mentioned this pull request Sep 16, 2024
Open
@scottwad scottwad mentioned this pull request Sep 24, 2024
Open
@mytamDo mytamDo mentioned this pull request Sep 24, 2024
Open
@raymondhtet raymondhtet mentioned this pull request Sep 25, 2024
Open
@nerds-github nerds-github mentioned this pull request Oct 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

@etimberg etimberg etimberg approved these changes

@LeeLenaleee LeeLenaleee LeeLenaleee left review comments

Assignees
No one assigned
Labels
type: enhancement type: types Typescript type changes
Projects
None yet
Milestone
Version 4.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dangreen @etimberg @kurkle @LeeLenaleee