Skip to content

Commit 753f4b6

Browse files
committed
avoid setPrototypeOf
1 parent 44d6861 commit 753f4b6

File tree

2 files changed

+11
-24
lines changed

2 files changed

+11
-24
lines changed

src/core/core.datasetController.js

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -149,20 +149,19 @@ function getFirstScaleId(chart, axis) {
149149
}
150150

151151
function createDatasetContext(parent, index, dataset) {
152-
return Object.setPrototypeOf(
152+
return Object.assign(Object.create(parent),
153153
{
154154
active: false,
155155
dataset,
156156
datasetIndex: index,
157157
index,
158158
type: 'dataset'
159-
},
160-
parent
159+
}
161160
);
162161
}
163162

164163
function createDataContext(parent, index, point, raw, element) {
165-
const context = {
164+
return Object.assign(Object.create(parent), {
166165
active: false,
167166
dataIndex: index,
168167
parsed: point,
@@ -171,9 +170,7 @@ function createDataContext(parent, index, point, raw, element) {
171170
index,
172171
mode: 'default',
173172
type: 'data'
174-
};
175-
Object.setPrototypeOf(context, parent);
176-
return context;
173+
});
177174
}
178175

179176
function clearStacks(meta, items) {

src/core/core.scale.js

Lines changed: 7 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -282,27 +282,17 @@ function skip(ticks, newTicks, spacing, majorStart, majorEnd) {
282282
}
283283

284284
function createScaleContext(parent, scale) {
285-
return Object.create(parent, {
286-
scale: {
287-
value: scale
288-
},
289-
type: {
290-
value: 'scale'
291-
}
285+
return Object.assign(Object.create(parent), {
286+
scale,
287+
type: 'scale'
292288
});
293289
}
294290

295291
function createTickContext(parent, index, tick) {
296-
return Object.create(parent, {
297-
tick: {
298-
value: tick
299-
},
300-
index: {
301-
value: index
302-
},
303-
type: {
304-
value: 'tick'
305-
}
292+
return Object.assign(Object.create(parent), {
293+
tick,
294+
index,
295+
type: 'tick'
306296
});
307297
}
308298

0 commit comments

Comments
 (0)