Remove zeroLineIndex functionality

Author: etimberg

docs/getting-started/v3-migration.md

@@ -26,6 +26,7 @@ Chart.js is no longer providing the `Chart.bundle.js` and `Chart.bundle.min.js`.
 ### Customizability
 
 * `custom` attribute of elements was removed. Please use scriptable options
+* The `zeroLine*` features of axes were removed.
 
 ### Options
 

src/core/core.scale.js

@@ -24,10 +24,6 @@ defaults._set('scale', {
 		drawOnChartArea: true,
 		drawTicks: true,
 		tickMarkLength: 10,
-		zeroLineWidth: 1,
-		zeroLineColor: 'rgba(0,0,0,0.25)',
-		zeroLineBorderDash: [],
-		zeroLineBorderDashOffset: 0.0,
 		offsetGridLines: false,
 		borderDash: [],
 		borderDashOffset: 0.0
@@ -324,9 +320,6 @@ function skip(ticks, spacing, majorStart, majorEnd) {
 }
 
 var Scale = Element.extend({
-
-	zeroLineIndex: 0,
-
 	/**
 	 * Parse a supported input value to internal representation.
 	 * @param {*} raw
@@ -1017,18 +1010,10 @@ var Scale = Element.extend({
 				continue;
 			}
 
-			if (i === me.zeroLineIndex && options.offset === offsetGridLines) {
-				// Draw the first index specially
-				lineWidth = gridLines.zeroLineWidth;
-				lineColor = gridLines.zeroLineColor;
-				borderDash = gridLines.zeroLineBorderDash || [];
-				borderDashOffset = gridLines.zeroLineBorderDashOffset || 0.0;
-			} else {
-				lineWidth = valueAtIndexOrDefault(gridLines.lineWidth, i, 1);
-				lineColor = valueAtIndexOrDefault(gridLines.color, i, 'rgba(0,0,0,0.1)');
-				borderDash = gridLines.borderDash || [];
-				borderDashOffset = gridLines.borderDashOffset || 0.0;
-			}
+			lineWidth = valueAtIndexOrDefault(gridLines.lineWidth, i, 1);
+			lineColor = valueAtIndexOrDefault(gridLines.color, i, 'rgba(0,0,0,0.1)');
+			borderDash = gridLines.borderDash || [];
+			borderDashOffset = gridLines.borderDashOffset || 0.0;
 
 			lineValue = getPixelForGridLine(me, tick._index || i, offsetGridLines);
 

src/scales/scale.linearbase.js

@@ -234,8 +234,6 @@ module.exports = Scale.extend({
 	generateTickLabels: function(ticks) {
 		var me = this;
 		me._tickValues = ticks.map(t => t.value);
-		me.zeroLineIndex = me._tickValues.indexOf(0);
-
 		Scale.prototype.generateTickLabels.call(me, ticks);
 	},
 

test/fixtures/core.scale/tick-drawing.json

@@ -19,8 +19,7 @@
                     "gridLines":{
                         "drawOnChartArea": false,
                         "drawBorder": false,
-                        "color": "rgba(0, 0, 0, 1)",
-                        "zeroLineColor": "rgba(0, 0, 0, 1)"
+                        "color": "rgba(0, 0, 0, 1)"
                     }
                 }, {
                     "type": "category",
@@ -32,8 +31,7 @@
                     "gridLines":{
                         "drawOnChartArea": false,
                         "drawBorder": false,
-                        "color": "rgba(0, 0, 0, 1)",
-                        "zeroLineColor": "rgba(0, 0, 0, 1)"
+                        "color": "rgba(0, 0, 0, 1)"
                     }
                 }],
                 "yAxes": [{

test/specs/scale.category.tests.js

@@ -29,10 +29,6 @@ describe('Category scale tests', function() {
 				lineWidth: 1,
 				offsetGridLines: false,
 				display: true,
-				zeroLineColor: 'rgba(0,0,0,0.25)',
-				zeroLineWidth: 1,
-				zeroLineBorderDash: [],
-				zeroLineBorderDashOffset: 0.0,
 				borderDash: [],
 				borderDashOffset: 0.0
 			},

test/specs/scale.linear.tests.js

@@ -23,10 +23,6 @@ describe('Linear Scale', function() {
 				lineWidth: 1,
 				offsetGridLines: false,
 				display: true,
-				zeroLineColor: 'rgba(0,0,0,0.25)',
-				zeroLineWidth: 1,
-				zeroLineBorderDash: [],
-				zeroLineBorderDashOffset: 0.0,
 				borderDash: [],
 				borderDashOffset: 0.0
 			},

test/specs/scale.logarithmic.tests.js

@@ -22,10 +22,6 @@ describe('Logarithmic Scale tests', function() {
 				lineWidth: 1,
 				offsetGridLines: false,
 				display: true,
-				zeroLineColor: 'rgba(0,0,0,0.25)',
-				zeroLineWidth: 1,
-				zeroLineBorderDash: [],
-				zeroLineBorderDashOffset: 0.0,
 				borderDash: [],
 				borderDashOffset: 0.0
 			},

test/specs/scale.radialLinear.tests.js

@@ -34,10 +34,6 @@ describe('Test the radial linear scale', function() {
 				lineWidth: 1,
 				offsetGridLines: false,
 				display: true,
-				zeroLineColor: 'rgba(0,0,0,0.25)',
-				zeroLineWidth: 1,
-				zeroLineBorderDash: [],
-				zeroLineBorderDashOffset: 0.0,
 				borderDash: [],
 				borderDashOffset: 0.0
 			},

test/specs/scale.time.tests.js

@@ -69,10 +69,6 @@ describe('Time scale tests', function() {
 				lineWidth: 1,
 				offsetGridLines: false,
 				display: true,
-				zeroLineColor: 'rgba(0,0,0,0.25)',
-				zeroLineWidth: 1,
-				zeroLineBorderDash: [],
-				zeroLineBorderDashOffset: 0.0,
 				borderDash: [],
 				borderDashOffset: 0.0
 			},