Skip to content

Commit 2fc98dd

Browse files
authored
Allow fill: true and null in ChartDataset.data (#8700)
* Handle `fill: true` * ChartDataset allow number/null data
1 parent e51a401 commit 2fc98dd

File tree

3 files changed

+26
-4
lines changed

3 files changed

+26
-4
lines changed

types/index.esm.d.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1966,7 +1966,7 @@ export interface FillerOptions {
19661966
propagate: boolean;
19671967
}
19681968

1969-
export type FillTarget = number | string | { value: number } | 'start' | 'end' | 'origin' | 'stack' | false;
1969+
export type FillTarget = number | string | { value: number } | 'start' | 'end' | 'origin' | 'stack' | boolean;
19701970

19711971
export interface ComplexFillTarget {
19721972
/**
@@ -3207,14 +3207,14 @@ export interface ChartTypeRegistry {
32073207
line: {
32083208
chartOptions: LineControllerChartOptions;
32093209
datasetOptions: LineControllerDatasetOptions & FillerControllerDatasetOptions;
3210-
defaultDataPoint: ScatterDataPoint;
3210+
defaultDataPoint: ScatterDataPoint | number | null;
32113211
parsedDataType: CartesianParsedData;
32123212
scales: keyof CartesianScaleTypeRegistry;
32133213
};
32143214
scatter: {
32153215
chartOptions: ScatterControllerChartOptions;
32163216
datasetOptions: ScatterControllerDatasetOptions;
3217-
defaultDataPoint: ScatterDataPoint;
3217+
defaultDataPoint: ScatterDataPoint | number | null;
32183218
parsedDataType: CartesianParsedData;
32193219
scales: keyof CartesianScaleTypeRegistry;
32203220
};
@@ -3249,7 +3249,7 @@ export interface ChartTypeRegistry {
32493249
radar: {
32503250
chartOptions: RadarControllerChartOptions;
32513251
datasetOptions: RadarControllerDatasetOptions;
3252-
defaultDataPoint: number;
3252+
defaultDataPoint: number | null;
32533253
parsedDataType: RadialParsedData;
32543254
scales: keyof RadialScaleTypeRegistry;
32553255
};

types/tests/dataset_null_data.ts

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
import { ChartDataset } from '../index.esm';
2+
3+
const dataset: ChartDataset = {
4+
data: [10, null, 20],
5+
};
6+
7+
const lineDataset: ChartDataset<'line'> = {
8+
data: [10, null, 20],
9+
};
10+
const scatterDataset: ChartDataset<'scatter'> = {
11+
data: [10, null, 20],
12+
};
13+
const radarDataset: ChartDataset<'radar'> = {
14+
data: [10, null, 20],
15+
};
16+
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
import { ChartDataset } from '../../../index.esm';
2+
3+
const dataset: ChartDataset = {
4+
data: [],
5+
fill: true,
6+
};

0 commit comments

Comments
 (0)