Review update

Author: kurkle

docs/general/performance.md

@@ -111,9 +111,9 @@ new Chart(ctx, {
 
 ### Enable spanGaps
 
-If you have a lot of data points, it can be more performant to enable spanGaps. This disables segmentation of line, which can be an unneeded step.
+If you have a lot of data points, it can be more performant to enable `spanGaps`. This disables segmentation of the line, which can be an unneeded step.
 
-To enable spanGaps:
+To enable `spanGaps`:
 
 ```javascript
 new Chart(ctx, {

src/elements/element.line.js

@@ -2,7 +2,7 @@
 
 import defaults from '../core/core.defaults';
 import Element from '../core/core.element';
-import {_bezierInterpolation, _pointInLine, _steppedInterpolation} from '../helpers/helpers.math';
+import {_bezierInterpolation, _pointInLine, _steppedInterpolation} from '../helpers/helpers.interpolation';
 import {_computeSegments, _boundSegments} from '../helpers/helpers.segment';
 import {_steppedLineTo, _bezierCurveTo} from '../helpers/helpers.canvas';
 import {_updateBezierControlPoints} from '../helpers/helpers.curve';

src/helpers/helpers.interpolation.js

@@ -0,0 +1,37 @@
+'use strict';
+
+/**
+ * @private
+ */
+export function _pointInLine(p1, p2, t) {
+	return {
+		x: p1.x + t * (p2.x - p1.x),
+		y: p1.y + t * (p2.y - p1.y)
+	};
+}
+
+/**
+ * @private
+ */
+export function _steppedInterpolation(p1, p2, t, mode) {
+	return {
+		x: p1.x + t * (p2.x - p1.x),
+		y: mode === 'middle' ? t < 0.5 ? p1.y : p2.y
+		: mode === 'after' ? t < 1 ? p1.y : p2.y
+		: t > 0 ? p2.y : p1.y
+	};
+}
+
+/**
+ * @private
+ */
+export function _bezierInterpolation(p1, p2, t) {
+	const cp1 = {x: p1.controlPointNextX, y: p1.controlPointNextY};
+	const cp2 = {x: p2.controlPointPreviousX, y: p2.controlPointPreviousY};
+	const a = _pointInLine(p1, cp1, t);
+	const b = _pointInLine(cp1, cp2, t);
+	const c = _pointInLine(cp2, p2, t);
+	const d = _pointInLine(a, b, t);
+	const e = _pointInLine(b, c, t);
+	return _pointInLine(d, e, t);
+}

src/helpers/helpers.math.js

@@ -132,42 +132,6 @@ export function distanceBetweenPoints(pt1, pt2) {
 	return Math.sqrt(Math.pow(pt2.x - pt1.x, 2) + Math.pow(pt2.y - pt1.y, 2));
 }
 
-/**
- * @private
- */
-export function _pointInLine(p1, p2, t) {
-	return {
-		x: p1.x + t * (p2.x - p1.x),
-		y: p1.y + t * (p2.y - p1.y)
-	};
-}
-
-/**
- * @private
- */
-export function _steppedInterpolation(p1, p2, t, mode) {
-	return {
-		x: p1.x + t * (p2.x - p1.x),
-		y: mode === 'middle' ? t < 0.5 ? p1.y : p2.y
-		: mode === 'after' ? t < 1 ? p1.y : p2.y
-		: t > 0 ? p2.y : p1.y
-	};
-}
-
-/**
- * @private
- */
-export function _bezierInterpolation(p1, p2, t) {
-	const cp1 = {x: p1.controlPointNextX, y: p1.controlPointNextY};
-	const cp2 = {x: p2.controlPointPreviousX, y: p2.controlPointPreviousY};
-	const a = _pointInLine(p1, cp1, t);
-	const b = _pointInLine(cp1, cp2, t);
-	const c = _pointInLine(cp2, p2, t);
-	const d = _pointInLine(a, b, t);
-	const e = _pointInLine(b, c, t);
-	return _pointInLine(d, e, t);
-}
-
 /**
  * Shortest distance between angles, in either direction.
  * @private