Skip to content

Commit 22ca8af

Browse files
authored
Fix/type dateadapter override (#8377)
* Not totally sure this is right , but since in core.adapters.js override is part of the dateadapter it seems logical it should be there. Should also fix #8369 * implemented feedback * Declare the dataAdapter since it will be available at runtime if someone overrides it * remove declaration. if this is giving problems in the future it might need te be added again
1 parent 505afa7 commit 22ca8af

File tree

2 files changed

+6
-12
lines changed

2 files changed

+6
-12
lines changed

types/adapters.d.ts

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
export type TimeUnit = 'millisecond' | 'second' | 'minute' | 'hour' | 'day' | 'week' | 'month' | 'quarter' | 'year';
22

3-
export interface DateAdapterBase {
3+
export interface DateAdapter {
4+
// Override one or multiple of the methods to adjust to the logic of the current date library.
5+
override(members: Partial<DateAdapter>): void;
6+
readonly options: any;
7+
48
/**
59
* Returns a map of time formats for the supported formatting units defined
610
* in Unit as well as 'datetime' representing a detailed date/time string.
@@ -54,16 +58,6 @@ export interface DateAdapterBase {
5458
endOf(timestamp: number, unit: TimeUnit | 'isoWeek'): number;
5559
}
5660

57-
export interface DateAdapter extends DateAdapterBase {
58-
readonly options: any;
59-
}
60-
61-
export const DateAdapter: {
62-
prototype: DateAdapter;
63-
new(options: any): DateAdapter;
64-
override(members: Partial<DateAdapter>): void;
65-
};
66-
6761
export const _adapters: {
6862
_date: DateAdapter;
6963
};

types/index.esm.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import {
2424
ScriptableAndArrayOptions
2525
} from './scriptable';
2626

27-
export { DateAdapterBase, DateAdapter, TimeUnit, _adapters } from './adapters';
27+
export { DateAdapter, TimeUnit, _adapters } from './adapters';
2828
export { Animation, Animations, Animator, AnimationEvent } from './animation';
2929
export { Color } from './color';
3030
export { Element } from './element';

0 commit comments

Comments
 (0)