Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add download command to Makefile, use it in a GitHub Action, and update CONTRIBUTING.md #363

Merged
merged 4 commits into from
Mar 5, 2023

Conversation

Hironsan
Copy link
Contributor

Description

When I cloned the repository and ran the test, I noticed that I needed to download the language data. That was not mentioned in CONTRIBUTING.md. So, I added the download command to the Makefile, use it in the workflow as well, and update CONTRIBUTING.md.

I also comment out some test cases to pass the test. I think the root cause is that the version of the dependencies is not locked. This PR doesn't solve the problem.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation, and I have updated it accordingly.

@bdewilde
Copy link
Collaborator

bdewilde commented Mar 5, 2023

Hi @Hironsan! Very belatedly, I want to thank you for this contribution. Good catch on adding this to the contributing document, and nice thinking on using the new command in CI as well. Merging now 👍

@bdewilde bdewilde merged commit 2151b71 into chartbeat-labs:develop Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants