Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansi: implement a new ansi.Scanner to replace ansi.Parser #239

Open
aymanbagabas opened this issue Nov 4, 2024 · 0 comments
Open

ansi: implement a new ansi.Scanner to replace ansi.Parser #239

aymanbagabas opened this issue Nov 4, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@aymanbagabas
Copy link
Member

Currently, the ansi.Parser API is hard to work with and feels flaky. We need a cleaner and Golang idiomatic way to parse sequences and text.

We might need to come up with a container type that can hold the scanned/parsed data to limit allocations. Limiting allocations should be optional, and defaults to unlimited allocations when not specified (or zero is used).

Should we drop the parser sub-package? Replace that with ansi.DecodeSequence? Are there any performance penalties for doing so? How will the new scanner API look like?

Related: #215

@aymanbagabas aymanbagabas added the enhancement New feature or request label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant