Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lint): update linter #405

Merged
merged 3 commits into from
Oct 21, 2024
Merged

chore(lint): update linter #405

merged 3 commits into from
Oct 21, 2024

Conversation

bashbunni
Copy link
Member

Uses the meta repo lint.yml. Deleted the lint-soft workflow as we don't have one declared in the meta repo

Copy link
Member

@aymanbagabas aymanbagabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need the golangci files in this repo anymore

@bashbunni
Copy link
Member Author

Ah ok, thank you! Just added a commit to remove them. Note that in the colorprofile repo, we still have golangci files too. Not sure if we still need them https://github.com/charmbracelet/colorprofile/blob/main/.golangci.yml

@aymanbagabas
Copy link
Member

aymanbagabas commented Oct 21, 2024

Ah ok, thank you! Just added a commit to remove them. Note that in the colorprofile repo, we still have golangci files too. Not sure if we still need them https://github.com/charmbracelet/colorprofile/blob/main/.golangci.yml

Thanks for noticing that, we don't need those files anymore as the shared workflow uses the golangci files from the meta repository

EDIT: I removed the files from colorprofile 🙂

@bashbunni bashbunni merged commit 80b4221 into master Oct 21, 2024
10 checks passed
@bashbunni bashbunni deleted the update-linter branch October 21, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants