Enable SSL #35
Open
Enable SSL #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable SSL in Apache
charlescng
reviewed
Oct 23, 2023
| LogLevel warn | ||
| CustomLog /opt/observium/logs/access_log combined | ||
| ServerSignature On | ||
| SSLEngine On |
There was a problem hiding this comment.
Adding HTTPS is fine but HTTP should still work. There should be a new virtual host on a different port for TLS.
charlescng
reviewed
Oct 25, 2023
| EXPOSE 8668/tcp | ||
|
|
||
| VOLUME ["/config","/opt/observium/logs","/opt/observium/rrd"] | ||
| VOLUME ["/config","/opt/observium/logs","/opt/observium/rrd","/opt/observium/certificates"] |
There was a problem hiding this comment.
I'm not sure if it should need another volume mapping just for the certificates.
Ideally, it should use Let's Encrypt's Certbot to automatically provision a certificate. DNS-01 challenges could make sense since I don't have my Observium exposed to the Internet.
There was a problem hiding this comment.
That's just how I had setup my environment. A separate directory is not necessary. I manage my own internal CA and do not expose Observium to the internet. The DNS-01 challenges from LetEncrypt should certainly work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These minor updates enables SSL in Apache, providing the user a secure connection when entering their login information at the login screen. It also resolves the mixed content issue for reverse proxies.
The user will need to create their own self signed certificates or obtain them from a service such as LetsEncrypt.