fixed insight model

charles96 · Aug 1, 2023 · 27e8200 · 27e8200
1 parent 34fc2a5
commit 27e8200
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 41 deletions.
diff --git a/Src/LineDevelopers.Tests/LineInsightClientTest.cs b/Src/LineDevelopers.Tests/LineInsightClientTest.cs
@@ -44,11 +44,11 @@ await _client.Message.SendBroadcastMessageAsync(new TextMessage("static test"),
                             }
                         });
                 
-                await Task.Delay(1000);
+                await Task.Delay(10000);
 
                 var result = await _client.Insight.GetUserInteractionStatisticsAsync(requestId);
 
-                That(result.Overview.RequestId, Is.EqualTo(requestId));
+                That(result.Overview.RequestId, Is.EqualTo(requestId),$"err : {result.Overview.RequestId} : {requestId}");
             });
         }
 
@@ -57,10 +57,13 @@ public void GetStatisticsPerUnitAsyncTest()
         {
             DoesNotThrowAsync(async () =>
             {
-                await _client.Insight.GetStatisticsPerUnitAsync("DUMMY", new DateOnly(2023, 04, 01), new DateOnly(2023, 04, 10));
+                var result = await _client.Insight.GetStatisticsPerUnitAsync("Promotion_TEST", new DateOnly(2023, 7, 31), new DateOnly(2023, 7, 31));
+                
+                That(result.Messages.Count, Is.EqualTo(2));
             });
         }
 
+
         [Test]
         public void GetNumberOfFollowersAsyncTest()
         {

diff --git a/Src/LineDevelopers/LineDevelopers.csproj b/Src/LineDevelopers/LineDevelopers.csproj
@@ -29,8 +29,4 @@
     </None>
   </ItemGroup>
 
-  <ItemGroup>
-    <Folder Include="Message\Content\" />
-  </ItemGroup>
-
 </Project>
diff --git a/Src/LineDevelopers/LineHttpClient.cs b/Src/LineDevelopers/LineHttpClient.cs
@@ -115,17 +115,6 @@ protected async Task<Stream> GetStreamAsync(string endpoint, Action<HttpResponse
             return await response.Content?.ReadAsStreamAsync();
         }
 
-        protected async Task<Stream> GetStreamAsync(string endpoint, Action<HttpContentHeaders,HttpResponseHeaders>? getResponseHeaders = null)
-        {
-            var response = await _httpClient.GetAsync(endpoint).ConfigureAwait(false);
-
-            if (getResponseHeaders != null) getResponseHeaders(response.Content.Headers, response.Headers);
-
-            await this.EnsureSuccessStatusCodeAsync(response).ConfigureAwait(false);
-
-            return await response.Content?.ReadAsStreamAsync();
-        }
-
         protected async Task PostAsync(string endpoint, StreamContent streamContent, MediaType mediaType, Action<HttpResponseHeaders>? getResponseHeaders = null)
         {
             using (var request = new HttpRequestMessage(HttpMethod.Post, endpoint))

diff --git a/Src/LineDevelopers/Message/Insights/StatisticsMessage.cs b/Src/LineDevelopers/Message/Insights/StatisticsMessage.cs
@@ -8,7 +8,8 @@ public class StatisticsMessage
         public int Seq { get; set; }
 
         [JsonPropertyName("impression")]
-        public int Impression { get; set; }
+        [JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]
+        public int? Impression { get; set; }
 
         [JsonPropertyName("mediaPlayed")]
         [JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]

diff --git a/Src/LineDevelopers/Message/LineContentClient.cs b/Src/LineDevelopers/Message/LineContentClient.cs