fix hostname params and add full-disable params #227

nikitasavchenko555 · 2023-01-16T14:15:53Z

ti-chi-bot · 2023-01-16T14:15:54Z

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot · 2023-01-16T14:16:01Z

Welcome @nikitasavchenko555!

It looks like this is your first PR to chaos-mesh/chaosd 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to chaos-mesh/chaosd. 😃

nikitasavchenko555 · 2023-01-16T14:17:42Z

/cc @Andrewmatilde @Colstuwjx @FingerLeader @Gallardot @Hexilee @QueenyJin

Hi!
Review, please

ti-chi-bot · 2023-01-16T14:17:43Z

@nikitasavchenko555: GitHub didn't allow me to request PR reviews from the following users: reviewer.

Note that only chaos-mesh members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @Reviewer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cwen0 · 2023-01-29T07:12:20Z

@nikitasavchenko555 Thanks for your contribution!

cwen0 · 2023-01-30T11:34:48Z

cmd/attack/network.go

@@ -114,6 +114,7 @@ func NewNetworkLossCommand(dep fx.Option, options *core.NetworkCommand) *cobra.C
 	cmd.Flags().StringVarP(&options.Hostname, "hostname", "H", "", "only impact traffic to these hostnames")
 	cmd.Flags().StringVarP(&options.IPProtocol, "protocol", "p", "",
 		"only impact traffic using this IP protocol, supported: tcp, udp, icmp, all")
+	cmd.Flags().BoolVar(&options.FullDisable, "full-disable", false, "full net on device disable flag")


This flag is also useful for other network attacks. Can you help to add this flag for other network attacks?

Yes, of course, I will supplement my commit with this in the near future

@cwen0 , I have added this flag for attacks that can implement it. Review, please.

cwen0 · 2023-02-01T07:15:27Z

cmd/attack/network.go

@@ -172,7 +174,7 @@ func NetworkDuplicateCommand(dep fx.Option, options *core.NetworkCommand) *cobra
 	cmd.Flags().StringVarP(&options.Hostname, "hostname", "H", "", "only impact traffic to these hostnames")
 	cmd.Flags().StringVarP(&options.IPProtocol, "protocol", "p", "",
 		"only impact traffic using this IP protocol, supported: tcp, udp, icmp, all")
-
+	cmd.Flags().BoolVar(&options.FullDisable, "full-disable", false, "network on device full disable flag")
 	return cmd
 }



Network Partition attack also needs full-disable flag.

@cwen0 , I tried to add it, but I got next stack trace, so I didn't add this flag in partition attack. But I will try find a reason and fix it.
I pointed out different directions, but it did not affect the result.

2023-02-01T11:35:17.044+0400 INFO chaosd/network.go:77 Set iptables chains {"request": "chains:{name:\"OUTPUT/443bf_021f4aaf66bac_\" direction:OUTPUT ipsets:\"\" target:\"DROP\"} chains:{name:\"INPUT/443bf_021f4aaf66bac_\" ipsets:\"\" target:\"DROP\"}"} 2023-02-01T11:35:17.059+0400 ERROR chaosd/network.go:77 error while setting iptables chains {"error": "error code: exit status 2, msg: iptables v1.8.7 (nf_tables): Set doesn't exist.\n\nTry `iptables -h' or 'iptables --help' for more information.\n", "errorVerbose": "error code: exit status 2, msg: iptables v1.8.7 (nf_tables): Set doesn't exist.\n\nTry `iptables -h' or 'iptables --help' for more information.\n\ngithub.com/chaos-mesh/chaos-mesh/pkg/chaosdaemon/util.EncodeOutputToError\n\t/home/nikita/go/pkg/mod/github.com/chaos-mesh/chaos-mesh@v0.9.1-0.20220812140450-4bc7ef589c13/pkg/chaosdaemon/util/util.go:118\ngithub.com/chaos-mesh/chaos-mesh/pkg/chaosdaemon.(*iptablesClient).ensureRule\n\t/home/nikita/go/pkg/mod/github.com/chaos-mesh/chaos-mesh@v0.9.1-0.20220812140450-4bc7ef589c13/pkg/chaosdaemon/iptables_server.go:256\ngithub.com/chaos-mesh/chaos-mesh/pkg/chaosdaemon.(*iptablesClient).deleteAndWriteRules\n\t/home/nikita/go/pkg/mod/github.com/chaos-mesh/chaos-mesh@v0.9.1-0.20220812140450-4bc7ef589c13/pkg/chaosdaemon/iptables_server.go:223\ngithub.com/chaos-mesh/chaos-mesh/pkg/chaosdaemon.(*iptablesClient).createNewChain\n\t/home/nikita/go/pkg/mod/github.com/chaos-mesh/chaos-mesh@v0.9.1-0.20220812140450-4bc7ef589c13/pkg/chaosdaemon/iptables_server.go:206\ngithub.com/chaos-mesh/chaos-mesh/pkg/chaosdaemon.(*iptablesClient).setIptablesChain\n\t/home/nikita/go/pkg/mod/github.com/chaos-mesh/chaos-mesh@v0.9.1-0.20220812140450-4bc7ef589c13/pkg/chaosdaemon/iptables_server.go:145\ngithub.com/chaos-mesh/chaos-mesh/pkg/chaosdaemon.(*iptablesClient).setIptablesChains\n\t/home/nikita/go/pkg/mod/github.com/chaos-mesh/chaos-mesh@v0.9.1-0.20220812140450-4bc7ef589c13/pkg/chaosdaemon/iptables_server.go:84\ngithub.com/chaos-mesh/chaos-mesh/pkg/chaosdaemon.(*DaemonServer).SetIptablesChains\n\t/home/nikita/go/pkg/mod/github.com/chaos-mesh/chaos-mesh@v0.9.1-0.20220812140450-4bc7ef589c13/pkg/chaosdaemon/iptables_server.go:54\ngithub.com/chaos-mesh/chaosd/pkg/server/chaosd.(*Server).applyIptables\n\t/home/nikita/work/chaosd_fork/pkg/server/chaosd/network.go:151\ngithub.com/chaos-mesh/chaosd/pkg/server/chaosd.networkAttack.Attack\n\t/home/nikita/work/chaosd_fork/pkg/server/chaosd/network.go:77\ngithub.com/chaos-mesh/chaosd/pkg/server/chaosd.(*Server).ExecuteAttack\n\t/home/nikita/work/chaosd_fork/pkg/server/chaosd/attack.go:105\ngithub.com/chaos-mesh/chaosd/cmd/attack.commonNetworkAttackFunc\n\t/home/nikita/work/chaosd_fork/cmd/attack/network.go:254\nreflect.Value.call\n\t/usr/local/go/src/reflect/value.go:584\nreflect.Value.Call\n\t/usr/local/go/src/reflect/value.go:368\ngo.uber.org/dig.defaultInvoker\n\t/home/nikita/go/pkg/mod/go.uber.org/dig@v1.14.1/container.go:220\ngo.uber.org/dig.(*Scope).Invoke\n\t/home/nikita/go/pkg/mod/go.uber.org/dig@v1.14.1/invoke.go:92\ngo.uber.org/fx.runInvoke\n\t/home/nikita/go/pkg/mod/go.uber.org/fx@v1.17.1/invoke.go:93\ngo.uber.org/fx.(*module).executeInvoke\n\t/home/nikita/go/pkg/mod/go.uber.org/fx@v1.17.1/module.go:174\ngo.uber.org/fx.(*module).executeInvokes\n\t/home/nikita/go/pkg/mod/go.uber.org/fx@v1.17.1/module.go:155\ngo.uber.org/fx.New\n\t/home/nikita/go/pkg/mod/go.uber.org/fx@v1.17.1/app.go:534\ngithub.com/chaos-mesh/chaosd/pkg/utils.FxNewAppWithoutLog\n\t/home/nikita/work/chaosd_fork/pkg/utils/utils.go:27\ngithub.com/chaos-mesh/chaosd/cmd/attack.NetworkPartitionCommand.func1\n\t/home/nikita/work/chaosd_fork/cmd/attack/network.go:189\ngithub.com/spf13/cobra.(*Command).execute\n\t/home/nikita/go/pkg/mod/github.com/spf13/cobra@v1.4.0/command.go:860\ngithub.com/spf13/cobra.(*Command).ExecuteC\n\t/home/nikita/go/pkg/mod/github.com/spf13/cobra@v1.4.0/command.go:974\ngithub.com/spf13/cobra.(*Command).Execute\n\t/home/nikita/go/pkg/mod/github.com/spf13/cobra@v1.4.0/command.go:902\nmain.main\n\t/home/nikita/work/chaosd_fork/cmd/main.go:79\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:250\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1594"} github.com/chaos-mesh/chaosd/pkg/server/chaosd.networkAttack.Attack /home/nikita/work/chaosd_fork/pkg/server/chaosd/network.go:77 github.com/chaos-mesh/chaosd/pkg/server/chaosd.(*Server).ExecuteAttack /home/nikita/work/chaosd_fork/pkg/server/chaosd/attack.go:105 github.com/chaos-mesh/chaosd/cmd/attack.commonNetworkAttackFunc /home/nikita/work/chaosd_fork/cmd/attack/network.go:254 reflect.Value.call /usr/local/go/src/reflect/value.go:584 reflect.Value.Call /usr/local/go/src/reflect/value.go:368 go.uber.org/dig.defaultInvoker /home/nikita/go/pkg/mod/go.uber.org/dig@v1.14.1/container.go:220 go.uber.org/dig.(*Scope).Invoke /home/nikita/go/pkg/mod/go.uber.org/dig@v1.14.1/invoke.go:92 go.uber.org/fx.runInvoke /home/nikita/go/pkg/mod/go.uber.org/fx@v1.17.1/invoke.go:93 go.uber.org/fx.(*module).executeInvoke /home/nikita/go/pkg/mod/go.uber.org/fx@v1.17.1/module.go:174 go.uber.org/fx.(*module).executeInvokes /home/nikita/go/pkg/mod/go.uber.org/fx@v1.17.1/module.go:155 go.uber.org/fx.New /home/nikita/go/pkg/mod/go.uber.org/fx@v1.17.1/app.go:534 github.com/chaos-mesh/chaosd/pkg/utils.FxNewAppWithoutLog /home/nikita/work/chaosd_fork/pkg/utils/utils.go:27 github.com/chaos-mesh/chaosd/cmd/attack.NetworkPartitionCommand.func1 /home/nikita/work/chaosd_fork/cmd/attack/network.go:189 github.com/spf13/cobra.(*Command).execute /home/nikita/go/pkg/mod/github.com/spf13/cobra@v1.4.0/command.go:860 github.com/spf13/cobra.(*Command).ExecuteC /home/nikita/go/pkg/mod/github.com/spf13/cobra@v1.4.0/command.go:974 github.com/spf13/cobra.(*Command).Execute /home/nikita/go/pkg/mod/github.com/spf13/cobra@v1.4.0/command.go:902 main.main /home/nikita/work/chaosd_fork/cmd/main.go:79 runtime.main /usr/local/go/src/runtime/proc.go:250 Error: error code: exit status 2, msg: iptables v1.8.7 (nf_tables): Set doesn't exist. Try `iptables -h' or 'iptables --help' for more information.```

@cwen0 , probably, reason of stack trace in this conditions:

Another network attack, that do not use this condition, don't create chains:

The chain is invalid. Network partition requires ip or hostname cannot both be empty at present.

You also can add a function to check it, like checkNetworkLimitParams

@cwen0 , I added it

Signed-off-by: Nikita Savchenko <nikisavchenko@ozon.ru>

cwen0

LGTM

nikitasavchenko555 · 2023-02-02T11:42:29Z

/assing @cwen0
Hi!
Thanks for review!
Merge, please

This reverts commit 6c378aa.

#235) This reverts commit 6c378aa.

ti-chi-bot added contribution first-time-contributor labels Jan 16, 2023

ti-chi-bot requested review from Hexilee and WangXiangUSTC January 16, 2023 14:16

ti-chi-bot added the size/S label Jan 16, 2023

nikitasavchenko555 force-pushed the fix_hostname_params branch 4 times, most recently from 773e322 to d723a5f Compare January 16, 2023 14:26

nikitasavchenko555 changed the title ~~fix hostname params and add full-disable params~~ fix hostname params and add full-disable params (#226) Jan 16, 2023

nikitasavchenko555 changed the title ~~fix hostname params and add full-disable params (#226)~~ fix hostname params and add full-disable params Jan 16, 2023

nikitasavchenko555 force-pushed the fix_hostname_params branch from d723a5f to 914fe3c Compare January 16, 2023 15:09

cwen0 self-requested a review January 29, 2023 07:11

nikitasavchenko555 force-pushed the fix_hostname_params branch from 914fe3c to e7f2fcc Compare January 29, 2023 20:54

cwen0 reviewed Jan 30, 2023

View reviewed changes

nikitasavchenko555 force-pushed the fix_hostname_params branch from e7f2fcc to 4c34ac5 Compare January 30, 2023 14:19

nikitasavchenko555 requested review from cwen0 and removed request for WangXiangUSTC and Hexilee January 30, 2023 14:50

nikitasavchenko555 force-pushed the fix_hostname_params branch 4 times, most recently from b6603eb to 0a692c7 Compare February 1, 2023 07:05

cwen0 reviewed Feb 1, 2023

View reviewed changes

nikitasavchenko555 requested a review from cwen0 February 1, 2023 09:16

nikitasavchenko555 force-pushed the fix_hostname_params branch 2 times, most recently from 4d0f573 to eee357a Compare February 2, 2023 07:19

fix hostname params and add full-disable params (chaos-mesh#226)

b56dba1

Signed-off-by: Nikita Savchenko <nikisavchenko@ozon.ru>

nikitasavchenko555 force-pushed the fix_hostname_params branch from eee357a to b56dba1 Compare February 2, 2023 07:36

cwen0 approved these changes Feb 2, 2023

View reviewed changes

cwen0 merged commit 6c378aa into chaos-mesh:main Feb 3, 2023

cwen0 added a commit that referenced this pull request Feb 8, 2023

Revert "fix hostname params and add full-disable params (#226) (#227)"

998215c

This reverts commit 6c378aa.

cwen0 mentioned this pull request Feb 8, 2023

Revert "fix hostname params and add full-disable params" #235

Merged

cwen0 added a commit that referenced this pull request Feb 8, 2023

Revert "fix hostname params and add full-disable params (#226) (#227)" (

e7715f7

#235) This reverts commit 6c378aa.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix hostname params and add full-disable params #227

fix hostname params and add full-disable params #227

nikitasavchenko555 commented Jan 16, 2023

ti-chi-bot commented Jan 16, 2023

ti-chi-bot commented Jan 16, 2023

nikitasavchenko555 commented Jan 16, 2023 •

edited

Loading

ti-chi-bot commented Jan 16, 2023

cwen0 commented Jan 29, 2023

cwen0 Jan 30, 2023

nikitasavchenko555 Jan 30, 2023

nikitasavchenko555 Jan 30, 2023

cwen0 Feb 1, 2023

nikitasavchenko555 Feb 1, 2023 •

edited

Loading

nikitasavchenko555 Feb 1, 2023

cwen0 Feb 1, 2023 •

edited

Loading

cwen0 Feb 1, 2023

nikitasavchenko555 Feb 1, 2023

cwen0 left a comment

nikitasavchenko555 commented Feb 2, 2023 •

edited

Loading

fix hostname params and add full-disable params #227

fix hostname params and add full-disable params #227

Conversation

nikitasavchenko555 commented Jan 16, 2023

ti-chi-bot commented Jan 16, 2023

ti-chi-bot commented Jan 16, 2023

nikitasavchenko555 commented Jan 16, 2023 • edited Loading

ti-chi-bot commented Jan 16, 2023

cwen0 commented Jan 29, 2023

cwen0 Jan 30, 2023

Choose a reason for hiding this comment

nikitasavchenko555 Jan 30, 2023

Choose a reason for hiding this comment

nikitasavchenko555 Jan 30, 2023

Choose a reason for hiding this comment

cwen0 Feb 1, 2023

Choose a reason for hiding this comment

nikitasavchenko555 Feb 1, 2023 • edited Loading

Choose a reason for hiding this comment

nikitasavchenko555 Feb 1, 2023

Choose a reason for hiding this comment

cwen0 Feb 1, 2023 • edited Loading

Choose a reason for hiding this comment

cwen0 Feb 1, 2023

Choose a reason for hiding this comment

nikitasavchenko555 Feb 1, 2023

Choose a reason for hiding this comment

cwen0 left a comment

Choose a reason for hiding this comment

nikitasavchenko555 commented Feb 2, 2023 • edited Loading

nikitasavchenko555 commented Jan 16, 2023 •

edited

Loading

nikitasavchenko555 Feb 1, 2023 •

edited

Loading

cwen0 Feb 1, 2023 •

edited

Loading

nikitasavchenko555 commented Feb 2, 2023 •

edited

Loading