debug logs

Author: Andarist

.github/workflows/ci.yaml

@@ -31,7 +31,7 @@ jobs:
       - run: pnpm build
       - run: pnpm lint
       - run: pnpm format:check
-      - run: pnpm test:integration
+      - run: pnpm test:integration --testPathPattern="git"
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           HEAD_OID: ${{ github.base_ref }}

src/test/integration/git.test.ts

@@ -170,13 +170,28 @@ const makeFileChanges = async (
     changegroup === "with-unchanged-symlink" ||
     changegroup === "with-changed-symlink"
   ) {
+    console.log("[DEBUG makeFileChanges] Creating some-dir directory");
     await fs.promises.mkdir(path.join(repoDirectory, "some-dir"), {
       recursive: true,
     });
+    console.log(
+      "[DEBUG makeFileChanges] Creating symlink ../README.md -> some-dir/nested",
+    );
     await fs.promises.symlink(
       "../README.md",
       path.join(repoDirectory, "some-dir", "nested"),
     );
+
+    // Verify symlink was created
+    const createdTarget = await fs.promises.readlink(
+      path.join(repoDirectory, "some-dir", "nested"),
+    );
+    console.log(
+      "[DEBUG makeFileChanges] Symlink created, target:",
+      createdTarget,
+    );
+
+    console.log("[DEBUG makeFileChanges] Setting git config user.email");
     await new Promise<void>((resolve) => {
       execFile(
         "git",
@@ -185,6 +200,7 @@ const makeFileChanges = async (
         () => resolve(),
       );
     });
+    console.log("[DEBUG makeFileChanges] Setting git config user.name");
     await new Promise<void>((resolve) => {
       execFile(
         "git",
@@ -193,19 +209,54 @@ const makeFileChanges = async (
         () => resolve(),
       );
     });
+    console.log("[DEBUG makeFileChanges] git.add some-dir/nested");
     await git.add({
       fs,
       dir: repoDirectory,
       filepath: "some-dir/nested",
     });
-    await git.commit({
+    console.log("[DEBUG makeFileChanges] git.commit 'Add symlink'");
+    const commitResult = await git.commit({
       fs,
       dir: repoDirectory,
       message: "Add symlink",
       author: { name: "Test", email: "test@test.com" },
     });
+    console.log("[DEBUG makeFileChanges] Commit created:", commitResult);
+
+    // Verify the symlink is in the commit
+    const commitObj = await git.readCommit({
+      fs,
+      dir: repoDirectory,
+      oid: commitResult,
+    });
+    const tree = await git.readTree({
+      fs,
+      dir: repoDirectory,
+      oid: commitObj.commit.tree,
+    });
+    const someDirEntry = tree.tree.find((e) => e.path === "some-dir");
+    console.log(
+      "[DEBUG makeFileChanges] some-dir entry after commit:",
+      JSON.stringify(someDirEntry),
+    );
+    if (someDirEntry) {
+      const someDirTree = await git.readTree({
+        fs,
+        dir: repoDirectory,
+        oid: someDirEntry.oid,
+      });
+      const nestedEntry = someDirTree.tree.find((e) => e.path === "nested");
+      console.log(
+        "[DEBUG makeFileChanges] some-dir/nested entry after commit:",
+        JSON.stringify(nestedEntry),
+      );
+    }
 
     if (changegroup === "with-changed-symlink") {
+      console.log(
+        "[DEBUG makeFileChanges] Changing symlink target to ../LICENSE",
+      );
       await fs.promises.rm(path.join(repoDirectory, "some-dir", "nested"));
       await fs.promises.symlink(
         "../LICENSE",
@@ -373,13 +424,16 @@ describe("git", () => {
       });
     }
 
-    it(`should allow unchanged symlinks without throwing`, async () => {
+    it.only(`should allow unchanged symlinks without throwing`, async () => {
       const branch = `${TEST_BRANCH_PREFIX}-unchanged-symlink`;
       branches.push(branch);
 
+      console.log("[DEBUG] Step 1: Creating test directory");
       await fs.promises.mkdir(testDir, { recursive: true });
       const repoDirectory = path.join(testDir, `repo-unchanged-symlink`);
+      console.log("[DEBUG] repoDirectory:", repoDirectory);
 
+      console.log("[DEBUG] Step 2: Cloning repo");
       await new Promise<void>((resolve, reject) => {
         const p = execFile(
           "git",
@@ -396,13 +450,90 @@ describe("git", () => {
         p.stdout?.pipe(process.stdout);
         p.stderr?.pipe(process.stderr);
       });
+      console.log("[DEBUG] Step 2 done: Clone completed");
 
+      console.log("[DEBUG] Step 3: Calling makeFileChanges");
       await makeFileChanges(repoDirectory, "with-unchanged-symlink");
+      console.log("[DEBUG] Step 3 done: makeFileChanges completed");
+
+      // Log symlink info
+      const symlinkPath = path.join(repoDirectory, "some-dir", "nested");
+      console.log("[DEBUG] Step 4: Checking symlink state");
+      try {
+        const symlinkTarget = await fs.promises.readlink(symlinkPath);
+        console.log("[DEBUG] Symlink target:", symlinkTarget);
+        const symlinkStat = await fs.promises.lstat(symlinkPath);
+        console.log(
+          "[DEBUG] Symlink lstat mode:",
+          symlinkStat.mode.toString(8),
+        );
+      } catch (e) {
+        console.log("[DEBUG] Error reading symlink:", e);
+      }
+
+      // Log git status
+      console.log("[DEBUG] Step 5: Git status in cloned repo");
+      const gitStatus = await git.statusMatrix({ fs, dir: repoDirectory });
+      const changedFiles = gitStatus.filter(
+        ([, head, workdir, stage]) =>
+          head !== workdir || head !== stage || workdir !== stage,
+      );
+      console.log("[DEBUG] Changed files count:", changedFiles.length);
+      console.log(
+        "[DEBUG] Changed files:",
+        JSON.stringify(changedFiles.slice(0, 20)),
+      );
+
+      // Log HEAD commit and symlink oid
+      console.log("[DEBUG] Step 6: Getting HEAD commit info");
+      const headCommit = await git.resolveRef({
+        fs,
+        dir: repoDirectory,
+        ref: "HEAD",
+      });
+      console.log("[DEBUG] HEAD commit:", headCommit);
+
+      try {
+        const commitObj = await git.readCommit({
+          fs,
+          dir: repoDirectory,
+          oid: headCommit,
+        });
+        console.log("[DEBUG] HEAD tree:", commitObj.commit.tree);
+
+        // Try to get the symlink entry from the tree
+        const tree = await git.readTree({
+          fs,
+          dir: repoDirectory,
+          oid: commitObj.commit.tree,
+        });
+        const someDirEntry = tree.tree.find((e) => e.path === "some-dir");
+        console.log(
+          "[DEBUG] some-dir entry in tree:",
+          JSON.stringify(someDirEntry),
+        );
+
+        if (someDirEntry) {
+          const someDirTree = await git.readTree({
+            fs,
+            dir: repoDirectory,
+            oid: someDirEntry.oid,
+          });
+          const nestedEntry = someDirTree.tree.find((e) => e.path === "nested");
+          console.log(
+            "[DEBUG] some-dir/nested entry in tree:",
+            JSON.stringify(nestedEntry),
+          );
+        }
+      } catch (e) {
+        console.log("[DEBUG] Error reading commit/tree:", e);
+      }
 
       // The symlink was committed locally and is unchanged in workdir.
       // The tree walk should skip it since oids match.
       // GitHub push may fail because local commit doesn't exist on GitHub,
       // but the key is that no symlink error is thrown.
+      console.log("[DEBUG] Step 7: Calling commitChangesFromRepo");
       try {
         await commitChangesFromRepo({
           octokit,
@@ -416,9 +547,12 @@ describe("git", () => {
           log,
         });
 
+        console.log("[DEBUG] Step 7 done: commitChangesFromRepo succeeded");
         await waitForGitHubToBeReady();
         await makeFileChangeAssertions(branch);
       } catch (error) {
+        console.log("[DEBUG] Step 7 error:", (error as Error).message);
+        console.log("[DEBUG] Full error:", error);
         expect((error as Error).message).not.toContain("Unexpected symlink");
         expect((error as Error).message).not.toContain("Unexpected executable");
       }