-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to customize branch
in runVersion
#254
Comments
Hm, so you have a workflow that starts in branch A but one that creates a branch B (or something like that) and you want to create a versioning PR from |
That's correct, we need to chain the |
I would accept a PR for this - we can bikeshed the input's name in the review comments. For now let's just go with a simple |
Thanks for the fast response! I created a PR with the desired change. Would love also feedback for #250 |
We have a similar usecase to this:
|
Hey @Andarist! Any updates on this? The PR is open and looks like a rather small change. |
Hey all, this is very interesting for our use case as well, we have a monorepo and and to have a different release PR for each package in the monorepo, we are doing a github action for each package using |
We're in an almost identical situation, would love to have the ability to use separate branches for each changeset PR. |
I wanted to test if the PR #255 would work but since actions runs from dist folder it's not possible to test the branch directly. Would be happy to help move the PR forward |
I ended up adding a hacky workflow that does the same thing as this action with custom branches: hacky workflow# Hack while custom branch is not officially supported in changeset action - https://github.com/changesets/action/issues/254 release_pr: name: Release PR if: ${{ github.event_name == 'push' && github.ref_name == 'develop' }} Maybe a better solution would be to instead solve #310 and #317 and let users handle the PR creation process on their own. |
Description
Hello, we recently implemented an automated release cycle via Changesets in OpenZeppelin contracts and we had problems trying to create a custom Github Actions Workflow with chained jobs using
needs: [...]
because it was impossible to tell the Changesets Action what branch to use. I think it'd be ideal to define it as an input.Basically, we just want to override this option.
Is there something to consider? We already merge the changesets integration but I'd love to send a PR with this change as well.
The text was updated successfully, but these errors were encountered: