Skip to content

Commit f276e71

Browse files
committed
Session: Ensure session ID exists in subscribeUsersToSession() and unsubscribe_user_from_session() - refs BT#20460
1 parent 9472790 commit f276e71

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

main/inc/lib/sessionmanager.lib.php

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2011,6 +2011,10 @@ public static function subscribeUsersToSession(
20112011
$tbl_session_rel_user = Database::get_main_table(TABLE_MAIN_SESSION_USER);
20122012
$tbl_session = Database::get_main_table(TABLE_MAIN_SESSION);
20132013

2014+
if (!self::isValidId($sessionId)) {
2015+
return false;
2016+
}
2017+
20142018
$session = api_get_session_entity($sessionId);
20152019

20162020
// from function parameter
@@ -2460,6 +2464,10 @@ public static function unsubscribe_user_from_session($session_id, $user_id)
24602464
$tbl_session_rel_user = Database::get_main_table(TABLE_MAIN_SESSION_USER);
24612465
$tbl_session = Database::get_main_table(TABLE_MAIN_SESSION);
24622466

2467+
if (!self::isValidId($session_id)) {
2468+
return false;
2469+
}
2470+
24632471
$sql = "DELETE FROM $tbl_session_rel_user
24642472
WHERE
24652473
session_id = $session_id AND

0 commit comments

Comments
 (0)