Merge pull request #5733 from christianbeeznest/ofaj-21911-3

Gradebook: Fix undefined user_id in Evaluation for edit - refs BT#21911

Author: christianbeeznest

public/main/gradebook/gradebook_edit_eval.php

@@ -39,9 +39,6 @@
     $evaluation->setTitle($values['name']);
     $evaluation->setDescription($values['description']);
 
-    $user = $entityManager->getRepository(User::class)->find($values['hid_user_id']);
-    $evaluation->setUser($user);
-
     $course = $entityManager->getRepository(Course::class)->findOneBy(['code' => $values['hid_course_code']]);
     $evaluation->setCourse($course);
 

public/main/gradebook/lib/fe/evalform.class.php

@@ -500,7 +500,7 @@ protected function build_editing_form()
             'hid_id' => $this->evaluation_object->get_id(),
             'name' => $this->evaluation_object->get_name(),
             'description' => $this->evaluation_object->get_description(),
-            'hid_user_id' => $this->evaluation_object->get_user_id(),
+            'hid_user_id' => $evaluation_object->user_id ?? 0,
             'hid_course_code' => $this->evaluation_object->get_course_code(),
             'hid_course_id' => $this->evaluation_object->getCourseId(),
             'hid_category_id' => $this->evaluation_object->get_category_id(),