Minor: Format code

Author: AngelFQC

main/inc/ajax/document.ajax.php

@@ -10,14 +10,14 @@
 switch ($action) {
     case 'get_dir_size':
         api_protect_course_script(true);
-        $path = isset($_GET['path']) ? $_GET['path'] : '';
+        $path = $_GET['path'] ?? '';
         $isAllowedToEdit = api_is_allowed_to_edit();
         $size = DocumentManager::getTotalFolderSize($path, $isAllowedToEdit);
         echo format_file_size($size);
         break;
     case 'get_dirs_size':
         api_protect_course_script(true);
-        $requests = isset($_GET['requests']) ? $_GET['requests'] : '';
+        $requests = $_GET['requests'] ?? '';
         $isAllowedToEdit = api_is_allowed_to_edit();
         $response = [];
         $requests = explode(',', $requests);
@@ -27,7 +27,7 @@
                 'id' => $request,
                 'size' => format_file_size($fileSize),
             ];
-            array_push($response, $data);
+            $response[] = $data;
         }
         echo json_encode($response);
         break;
@@ -114,7 +114,7 @@
             $directoryParentId = isset($_POST['directory_parent_id']) ? (int) $_POST['directory_parent_id'] : 0;
             $currentDirectory = '';
             if (empty($directoryParentId)) {
-                $currentDirectory = isset($_REQUEST['curdirpath']) ? $_REQUEST['curdirpath'] : '';
+                $currentDirectory = $_REQUEST['curdirpath'] ?? '';
             } else {
                 $documentData = DocumentManager::get_document_data_by_id($directoryParentId, api_get_course_id());
                 if ($documentData) {
@@ -124,7 +124,7 @@
             if (empty($currentDirectory)) {
                 $currentDirectory = DIRECTORY_SEPARATOR;
             }
-            $ifExists = isset($_POST['if_exists']) ? $_POST['if_exists'] : '';
+            $ifExists = $_POST['if_exists'] ?? '';
             $unzip = isset($_POST['unzip']) ? 1 : 0;
 
             if (empty($ifExists)) {
@@ -189,7 +189,7 @@
                             get_lang('Uploaded')
                         );
                     } else {
-                        $json['name'] = isset($file['name']) ? $file['name'] : get_lang('Unknown');
+                        $json['name'] = $file['name'] ?? get_lang('Unknown');
                         $json['url'] = '';
                         $json['error'] = get_lang('Error');
                     }
@@ -275,7 +275,7 @@
         break;
     case 'document_destination':
         //obtained the bootstrap-select selected value via ajax
-        $dirValue = isset($_POST['dirValue']) ? $_POST['dirValue'] : null;
+        $dirValue = $_POST['dirValue'] ?? null;
         echo Security::remove_XSS($dirValue);
         break;
 }

main/inc/lib/fileUpload.lib.php

@@ -739,17 +739,11 @@ function handle_uploaded_document(
     }
 }
 
-/**
- * @param string $file
- * @param string $storePath
- *
- * @return bool
- */
-function moveUploadedFile($file, $storePath)
+function moveUploadedFile(array $file, string $storePath): bool
 {
-    $handleFromFile = isset($file['from_file']) && $file['from_file'] ? true : false;
-    $moveFile = isset($file['move_file']) && $file['move_file'] ? true : false;
-    $copyFile = isset($file['copy_file']) && $file['copy_file'] ? true : false;
+    $handleFromFile = isset($file['from_file']) && $file['from_file'];
+    $moveFile = isset($file['move_file']) && $file['move_file'];
+    $copyFile = isset($file['copy_file']) && $file['copy_file'];
     if ($moveFile) {
         $copied = copy($file['tmp_name'], $storePath);